Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aws-lambda-go): remove hard coded references in tests to @aws-cdk packages #15826

Merged
merged 3 commits into from
Jul 30, 2021
Merged

test(aws-lambda-go): remove hard coded references in tests to @aws-cdk packages #15826

merged 3 commits into from
Jul 30, 2021

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Jul 29, 2021

Remove all hard coded references to the @aws-cdk/aws-lambda and @aws-cdk/aws-lambda-go packages from the tests which should fix the issue that prevent building the aws-cdk-lib package.

Resolves #15585


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…s-cdk-lib package

remove all hard coded references to the @aws-cdk/aws-lambda and @aws-cdk/aws-lambda-go packages

re #15585
@gitpod-io
Copy link

gitpod-io bot commented Jul 29, 2021

@skinny85
Copy link
Contributor

Thanks so much for the contribution @corymhall!

Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 'n easy. Thanks for the fix!

@mergify
Copy link
Contributor

mergify bot commented Jul 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3641445
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 564550d into aws:master Jul 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
…packages (aws#15826)

Remove all hard coded references to the @aws-cdk/aws-lambda and @aws-cdk/aws-lambda-go packages from the tests which should fix the issue that prevent building the aws-cdk-lib package.

Resolves aws#15585


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch added a commit that referenced this pull request Aug 6, 2021
…-lambda

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the aws-cdk-lib package.

Copied from (and kudos to!) #15826

Related #15586
mergify bot pushed a commit that referenced this pull request Aug 6, 2021
…-lambda (#15921)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the aws-cdk-lib package.

Copied from (and kudos to!) #15826

Related #15586


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…packages (aws#15826)

Remove all hard coded references to the @aws-cdk/aws-lambda and @aws-cdk/aws-lambda-go packages from the tests which should fix the issue that prevent building the aws-cdk-lib package.

Resolves aws#15585


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…-lambda (aws#15921)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the aws-cdk-lib package.

Copied from (and kudos to!) aws#15826

Related aws#15586


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
…packages (aws#15826)

Remove all hard coded references to the @aws-cdk/aws-lambda and @aws-cdk/aws-lambda-go packages from the tests which should fix the issue that prevent building the aws-cdk-lib package.

Resolves aws#15585


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
…-lambda (aws#15921)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the aws-cdk-lib package.

Copied from (and kudos to!) aws#15826

Related aws#15586


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle the tests of the @aws-cdk/aws-lambda-go module in the V2 build of experimental modules
4 participants