Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the tests of the @aws-cdk/aws-lambda-python module in the V2 build of the experimental modules #15586

Closed
2 tasks
skinny85 opened this issue Jul 15, 2021 · 2 comments
Closed
2 tasks

Handle the tests of the @aws-cdk/aws-lambda-python module in the V2 build of the experimental modules #15586

skinny85 opened this issue Jul 15, 2021 · 2 comments
Assignees
@njlynch @madeline-k
Labels
@aws-cdk/aws-lambda-python aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. investigating This issue is being investigated and/or work is in progress to resolve the issue. p1

Comments

@skinny85
Copy link
Contributor

skinny85 commented Jul 15, 2021 •
edited
Loading

The module currently has 2 problems that prevent it from being correctly built by the @aws-cdk-lib package:

These need to be fixed, and the package added to the build of @aws-cdk-lib (by removing this exclusion).
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Jul 15, 2021
@skinny85 skinny85 added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Jul 15, 2021
@madeline-k madeline-k added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Jul 26, 2021
@madeline-k madeline-k self-assigned this Jul 26, 2021
@skinny85
Copy link
Contributor Author

This should probably be done in a very similar fashion to #15826, which was solving a very similar issue (#15585) for the @aws-cdk/aws-lambda-go package.

njlynch added a commit that referenced this issue Aug 6, 2021
@njlynch
test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws…
09e9f81 
…-lambda

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the aws-cdk-lib package.

Copied from (and kudos to!) #15826

Related #15586
@njlynch njlynch mentioned this issue Aug 6, 2021
Merged
@njlynch njlynch self-assigned this Aug 6, 2021
mergify bot pushed a commit that referenced this issue Aug 6, 2021
@njlynch
test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws…
4f65bd8 
…-lambda (#15921)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the aws-cdk-lib package.

Copied from (and kudos to!) #15826

Related #15586


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch added a commit that referenced this issue Aug 11, 2021
@njlynch
test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws…
ffe6759 
…-lambda

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the package as an alpha module in v2.

related #15586
@njlynch njlynch mentioned this issue Aug 11, 2021
Merged
mergify bot pushed a commit that referenced this issue Aug 11, 2021
@njlynch
test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws…
e17c627 
…-lambda (#15994)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the package as an alpha module in v2.

This was previously done in #15921, but I missed these entries in the tests.

related #15586

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch added a commit that referenced this issue Aug 11, 2021
@njlynch
chore: fix alpha build of lambda-go/python packages
646c066 
Now that the hard-coded refernces to @aws-cdk/aws-lambda have been removed from
these packages, we can publish them as "normal" alpha modules. This just
involves removing the special config from both package.jsons.

Note this is also forward-porting #15994 from master, which was missed in the
original change to make these packages v2-compliant. We _could_ just wait for
the next forward merge job, but wanting to close this out while I still have
context.

closes #15586
closes #15585
@njlynch njlynch mentioned this issue Aug 11, 2021
Merged
mergify bot pushed a commit that referenced this issue Aug 23, 2021
@njlynch
chore: fix alpha build of lambda-go/python packages (#15995)
c90af3f 
Remove the hard-coded refernces to @aws-cdk/aws-lambda from
these packages, and publish them as "normal" alpha modules. This just
involves removing the special config from both package.jsons.

Note this is also forward-porting #15994 from master, which was missed in the
original change to make these packages v2-compliant. We _could_ just wait for
the next forward merge job, but wanting to close this out while I still have
context.

closes #15586
closes #15585


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@njlynch njlynch closed this as completed Aug 23, 2021
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@njlynch @hollanddd
test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws…
45c5699 
…-lambda (aws#15921)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the aws-cdk-lib package.

Copied from (and kudos to!) aws#15826

Related aws#15586


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@njlynch @hollanddd
test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws…
941248e 
…-lambda (aws#15994)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the package as an alpha module in v2.

This was previously done in aws#15921, but I missed these entries in the tests.

related aws#15586

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this issue Sep 7, 2021
@njlynch @david-doyle-as24
test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws…
3ee446a 
…-lambda (aws#15921)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the aws-cdk-lib package.

Copied from (and kudos to!) aws#15826

Related aws#15586


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this issue Sep 7, 2021
@njlynch @david-doyle-as24
test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws…
e2cd51c 
…-lambda (aws#15994)

Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the package as an alpha module in v2.

This was previously done in aws#15921, but I missed these entries in the tests.

related aws#15586

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

@madeline-k madeline-k

Labels
@aws-cdk/aws-lambda-python aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. investigating This issue is being investigated and/or work is in progress to resolve the issue. p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skinny85 @njlynch @nija-at @madeline-k