test(aws-lambda-python): remove hard-coded references to @aws-cdk/aws-lambda #15994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-lambda Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the test, which should fix the issue that prevent building the package as an alpha module in v2. related #15586
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
otaviomacedo
approved these changes
Aug 11, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
added a commit
that referenced
this pull request
Aug 11, 2021
Now that the hard-coded refernces to @aws-cdk/aws-lambda have been removed from these packages, we can publish them as "normal" alpha modules. This just involves removing the special config from both package.jsons. Note this is also forward-porting #15994 from master, which was missed in the original change to make these packages v2-compliant. We _could_ just wait for the next forward merge job, but wanting to close this out while I still have context. closes #15586 closes #15585
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
Remove the hard-coded refernces to @aws-cdk/aws-lambda from these packages, and publish them as "normal" alpha modules. This just involves removing the special config from both package.jsons. Note this is also forward-porting #15994 from master, which was missed in the original change to make these packages v2-compliant. We _could_ just wait for the next forward merge job, but wanting to close this out while I still have context. closes #15586 closes #15585 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…-lambda (aws#15994) Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the test, which should fix the issue that prevent building the package as an alpha module in v2. This was previously done in aws#15921, but I missed these entries in the tests. related aws#15586 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
…-lambda (aws#15994) Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the test, which should fix the issue that prevent building the package as an alpha module in v2. This was previously done in aws#15921, but I missed these entries in the tests. related aws#15586 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the hard coded reference to the @aws-cdk/aws-lambda packages from the
test, which should fix the issue that prevent building the package as an alpha module in v2.
This was previously done in #15921, but I missed these entries in the tests.
related #15586
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license