Skip to content

Commit

Permalink
chore: fix alpha build of lambda-go/python packages
Browse files Browse the repository at this point in the history
Now that the hard-coded refernces to @aws-cdk/aws-lambda have been removed from
these packages, we can publish them as "normal" alpha modules. This just
involves removing the special config from both package.jsons.

Note this is also forward-porting #15994 from master, which was missed in the
original change to make these packages v2-compliant. We _could_ just wait for
the next forward merge job, but wanting to close this out while I still have
context.

closes #15586
closes #15585
  • Loading branch information
njlynch committed Aug 11, 2021
1 parent fb5dc58 commit 646c066
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-lambda-go/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,5 @@
"publishConfig": {
"tag": "next"
},
"separate-module": false,
"private": true
}
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-lambda-python/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@
"docker"
]
},
"separate-module": false,
"publishConfig": {
"tag": "latest"
}
Expand Down
6 changes: 3 additions & 3 deletions packages/@aws-cdk/aws-lambda-python/test/function.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ test('PythonFunction with defaults', () => {
});

expect(bundle).toHaveBeenCalledWith(expect.objectContaining({
entry: expect.stringMatching(/@aws-cdk\/aws-lambda-python\/test\/lambda-handler$/),
entry: expect.stringMatching(/aws-lambda-python\/test\/lambda-handler$/),
outputPathSuffix: '.',
}));

Expand All @@ -65,7 +65,7 @@ test('PythonFunction with index in a subdirectory', () => {
});

expect(bundle).toHaveBeenCalledWith(expect.objectContaining({
entry: expect.stringMatching(/@aws-cdk\/aws-lambda-python\/test\/lambda-handler-sub$/),
entry: expect.stringMatching(/aws-lambda-python\/test\/lambda-handler-sub$/),
outputPathSuffix: '.',
}));

Expand Down Expand Up @@ -142,4 +142,4 @@ test('allows specifying hash type', () => {
S3Key: 'MY_CUSTOM_HASH',
},
});
});
});

0 comments on commit 646c066

Please sign in to comment.