feat(cli): hotswap deployments for StepFunctions State Machines #16489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons result in full deployments
…sts which verify that functions updated without providing FunctionName parameters can work (lambda only, still need to do step functions
|
|
|
Almost there 🙂 |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
…tem (#16696) The current functionality we use for evaluating CloudFormation in the hotswap part of the CLI is very limited: only allows substituting the values of parameters used for Assets. That's not good enough when doing substitutions for StepFunctions State Machines from [this PR](#16489), for example. Enhance the capabilities of the CFN eval sub-system by introducing a new class, `CloudFormationExecutableTemplate`, that allows resolving references to resources inside the template. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
This adds support for `StepFunctions::StateMachines` to be hotswapped. Only changes to the `DefinitionString` property will trigger hotswaps. Changes to other properties (or resources, except Lambda functions) will require full deployments. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…tem (aws#16696) The current functionality we use for evaluating CloudFormation in the hotswap part of the CLI is very limited: only allows substituting the values of parameters used for Assets. That's not good enough when doing substitutions for StepFunctions State Machines from [this PR](aws#16489), for example. Enhance the capabilities of the CFN eval sub-system by introducing a new class, `CloudFormationExecutableTemplate`, that allows resolving references to resources inside the template. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…16489) This adds support for `StepFunctions::StateMachines` to be hotswapped. Only changes to the `DefinitionString` property will trigger hotswaps. Changes to other properties (or resources, except Lambda functions) will require full deployments. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
StepFunctions::StateMachinesto be hotswapped. Only changes to theDefinitionStringproperty will trigger hotswaps. Changes to other properties (or resources, except Lambda functions) will require full deployments.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license