Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): add more capabilities to the hotswap CFN evaluate sub-system #16696

Merged
merged 12 commits into from
Sep 30, 2021

Conversation

skinny85
Copy link
Contributor

The current functionality we use for evaluating CloudFormation in the hotswap part of the CLI is very limited:
only allows substituting the values of parameters used for Assets.
That's not good enough when doing substitutions for StepFunctions State Machines from
this PR, for example.

Enhance the capabilities of the CFN eval sub-system by introducing a new class,
CloudFormationExecutableTemplate, that allows resolving references to resources inside the template.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from rix0rrr September 28, 2021 21:19
@skinny85 skinny85 self-assigned this Sep 28, 2021
@gitpod-io
Copy link

gitpod-io bot commented Sep 28, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 28, 2021
@skinny85 skinny85 requested a review from rix0rrr September 30, 2021 03:56
@skinny85
Copy link
Contributor Author

@rix0rrr thanks for the review! I've incorporated all of your comments, would appreciate another pass!

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Sep 30, 2021
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisional okeedoke, do with my remaining comments as you will

@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label Sep 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e00d8a2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 810d2d9 into aws:master Sep 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 deleted the hotswap/cfn-exec branch September 30, 2021 23:39
njlynch pushed a commit that referenced this pull request Oct 11, 2021
…tem (#16696)

The current functionality we use for evaluating CloudFormation in the hotswap part of the CLI is very limited:
only allows substituting the values of parameters used for Assets.
That's not good enough when doing substitutions for StepFunctions State Machines from
[this PR](#16489), for example.

Enhance the capabilities of the CFN eval sub-system by introducing a new class,
`CloudFormationExecutableTemplate`, that allows resolving references to resources inside the template.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…tem (aws#16696)

The current functionality we use for evaluating CloudFormation in the hotswap part of the CLI is very limited:
only allows substituting the values of parameters used for Assets.
That's not good enough when doing substitutions for StepFunctions State Machines from
[this PR](aws#16489), for example.

Enhance the capabilities of the CFN eval sub-system by introducing a new class,
`CloudFormationExecutableTemplate`, that allows resolving references to resources inside the template.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants