feat(aws-eks): add construct library for EKS #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original work done by @IPyandy
Generalize and conformize adding AutoScalingGroup capacity to both ECS and EKS clusters, as well as naming consistency among variables and with Application AutoScaling. BREAKING CHANGE: For `AutoScalingGroup`, renamed `minSize` => `minCapacity`, `maxSize` => `maxCapacity`, for consistency with `desiredCapacity` and also Application AutoScaling. For ECS's `addDefaultAutoScalingGroupCapacity()`, `instanceCount` => `desiredCapacity` and the function now takes an ID (pass `"DefaultAutoScalingGroup"` to avoid interruption to your deployments).
RomainMuller
approved these changes
Feb 1, 2019
eladb
approved these changes
Feb 4, 2019
| * | ||
| * The nodes will automatically be configured with the right VPC and AMI | ||
| * for the instance type and Kubernetes version. | ||
| */ |
There was a problem hiding this comment.
Should also be possible to do via ctor (thinking of deCDK)
| * | ||
| * Prefer to use `addWorkerNodes` if possible. | ||
| */ | ||
| public addAutoScalingGroup(autoScalingGroup: autoscaling.AutoScalingGroup, options: AddAutoScalingGroupOptions) { |
There was a problem hiding this comment.
Maybe add a link ref to what this is doing under the hood
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct library to set up an EKS cluster and add nodes to it.
Generalizes adding AutoScalingGroup capacity and make it the same
between both ECS and EKS clusters. Fixes naming inconsistencies
among properties of
AutoScalingGroup, and between EC2 AutoScaling andApplication AutoScaling.
This PR takes #991 but reimplements the API in the style of the ECS library.
BREAKING CHANGE: For
AutoScalingGroup, renamedminSize=>minCapacity,maxSize=>maxCapacity, for consistency withdesiredCapacityand also Application AutoScaling.For ECS's
addDefaultAutoScalingGroupCapacity(),instanceCount=>desiredCapacityand the function now takes an ID (pass"DefaultAutoScalingGroup"to avoid interruption to your deployments).Again, unit tests are lacking for now, would like feedback on the shape of the API first.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.