Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-eks): add construct library for EKS #1655

Merged
merged 12 commits into from
Feb 8, 2019
Merged

feat(aws-eks): add construct library for EKS #1655

merged 12 commits into from
Feb 8, 2019

Commits on Jan 31, 2019

  1. Work from the branch 

    Original work done by @IPyandy
    @rix0rrr
    rix0rrr committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    f1d7c86 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Rewrite EKS API to make it more in line with ECS API 

    Generalize and conformize adding AutoScalingGroup capacity to both ECS
and EKS clusters, as well as naming consistency among variables and with
Application AutoScaling.

BREAKING CHANGE: For `AutoScalingGroup`, renamed `minSize` =>
`minCapacity`, `maxSize` => `maxCapacity`, for consistency with
`desiredCapacity` and also Application AutoScaling.

For ECS's `addDefaultAutoScalingGroupCapacity()`, `instanceCount` =>
`desiredCapacity` and the function now takes an ID (pass
`"DefaultAutoScalingGroup"` to avoid interruption to your deployments).
    @rix0rrr
    rix0rrr committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    873a19d View commit details
    Browse the repository at this point in the history

  2. Get rid of EKS cluster example, the integ test does it all

    @rix0rrr
    rix0rrr committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    6852877 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. BasicAutoScalingGroupProps => CommonAutoScalingGroupProps

    @rix0rrr
    rix0rrr committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    f37065c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into huijbers/eks-cp

    @rix0rrr
    rix0rrr committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    6d2bf8f View commit details
    Browse the repository at this point in the history

  3. Review comments

    @rix0rrr
    rix0rrr committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    af00ae0 View commit details
    Browse the repository at this point in the history

  4. Fix static checks

    @rix0rrr
    rix0rrr committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    7bab6d4 View commit details
    Browse the repository at this point in the history

  5. Don't fail GenericLinuxImage in integ test mode

    @rix0rrr
    rix0rrr committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    cfcffb9 View commit details
    Browse the repository at this point in the history

  6. Add tests

    @rix0rrr
    rix0rrr committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    c4eeef2 View commit details
    Browse the repository at this point in the history

  7. Update more ECS tests

    @rix0rrr
    rix0rrr committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    1416768 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into huijbers/eks-cp

    @rix0rrr
    rix0rrr committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    5de445e View commit details
    Browse the repository at this point in the history

  9. Exercise export to make coverage checker happy

    @rix0rrr
    rix0rrr committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    dc6d4df View commit details
    Browse the repository at this point in the history