chore(assertions): remove rosetta:extract from build command
#17076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This form of executing Rosetta is not mocked by the jsii integ tests (which try executing a CDK build using a new version of the jsii tools). The jsii integ tests rely on passing environment variables `$CDK_BUILD_JSII`, `$PACMAK` and `$ROSETTA` (instead of replacing symlinks in the Node module farm). This leads to the generation of `.jsii.tabl.json` during build using the NPM-installed version of `jsii-rosetta`, which subsequently interferes with the run of `$PACMAK` which *is* the new version (since Rosetta tablets are supposed to be short-lived, there is no backwards compatibility guarantee between different versions). There will be a supported mechanism to achieve what this single post-build command is trying to achieve, so remove it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit ac54842)
|
|
rix0rrr
approved these changes
Oct 20, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This form of executing Rosetta is not mocked by the jsii integ tests
(which try executing a CDK build using a new version of the jsii tools).
The jsii integ tests rely on passing environment variables
$CDK_BUILD_JSII,$PACMAKand$ROSETTA(instead of replacing symlinks in the Node module farm).This leads to the generation of
.jsii.tabl.jsonduring build using theNPM-installed version of
jsii-rosetta, which subsequently interferes withthe run of
$PACMAKwhich is the new version (since Rosetta tabletsare supposed to be short-lived, there is no backwards compatibility guarantee
between different versions).
There will be a supported mechanism to achieve what this single post-build command is trying to achieve,
so remove it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
(cherry picked from commit ac54842)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license