Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update DEPRECATED_APIs.md and introduce new plaintext format #17120

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Oct 22, 2021

As part of the upcoming v2 GA, we need to update (and lock in) the final list of
deprecated APIs that will be removed from V2. At the same time, we need to
create the input for jsii's new --strip-deprecated file input, where only a
subset of deprecated items are stripped away (see #16566). This change does both
by introducing a new output format for list-deprecated-apis and feeding that
value into jsii at compile time.

fixes #16566


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

As part of the upcoming v2 GA, we need to update (and lock in) the final list of
deprecated APIs that will be removed from V2. At the same time, we need to
create the input for `jsii`'s new `--strip-deprecated` file input, where only a
subset of deprecated items are stripped away (see #16566). This change does both
by introducing a new output format for `list-deprecated-apis` and feeding that
value into `jsii` at compile time.

fixes #16566
@njlynch njlynch requested review from rix0rrr and a team October 22, 2021 15:19
@njlynch njlynch self-assigned this Oct 22, 2021
@gitpod-io
Copy link

gitpod-io bot commented Oct 22, 2021

@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Oct 22, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 22, 2021
@nija-at nija-at removed their assignment Oct 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2b85306
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a852857 into master Oct 27, 2021
@mergify mergify bot deleted the njlynch/list-deprecated branch October 27, 2021 11:48
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

njlynch added a commit that referenced this pull request Nov 1, 2021
This is a continuation (and the final piece!) of
aws/jsii#3085 and
#17120.

Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.

closes #16566
mergify bot pushed a commit that referenced this pull request Nov 1, 2021
This is a continuation (and the final piece!) of aws/jsii#3085 and #17120.

Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.

closes #16566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ws#17120)

As part of the upcoming v2 GA, we need to update (and lock in) the final list of
deprecated APIs that will be removed from V2. At the same time, we need to
create the input for `jsii`'s new `--strip-deprecated` file input, where only a
subset of deprecated items are stripped away (see aws#16566). This change does both
by introducing a new output format for `list-deprecated-apis` and feeding that
value into `jsii` at compile time.

fixes aws#16566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
This is a continuation (and the final piece!) of aws/jsii#3085 and aws#17120.

Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.

closes aws#16566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CDKv2GA]: Support new @deprecations post-GA
4 participants