-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use fixed deprecated list for strip-deprecated #17260
Conversation
This is a continuation (and the final piece!) of aws/jsii#3085 and #17120. Changes cdk-build to use the fixed deprecated list, rather than stripping all deprecated elements. This will enable us to deprecate new elements going forward without stripping them from v2 and breaking customers. closes #16566
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do-not-merge
so I'm sure you get to see this.
Do we have launch day task (or pre-launch day task) that includes generating a final list of the deprecated APIs?
Frankly, I'm considering the list generated in #17120 the final list. I'll send out a broader notice/announcement looking to see if anyone else has any last-minute deprecations that must get in. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This is a continuation (and the final piece!) of aws/jsii#3085 and aws#17120. Changes cdk-build to use the fixed deprecated list, rather than stripping all deprecated elements. This will enable us to deprecate new elements going forward without stripping them from v2 and breaking customers. closes aws#16566 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is a continuation (and the final piece!) of aws/jsii#3085 and #17120.
Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.
closes #16566
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license