Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use fixed deprecated list for strip-deprecated #17260

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Nov 1, 2021

This is a continuation (and the final piece!) of aws/jsii#3085 and #17120.

Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.

closes #16566


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This is a continuation (and the final piece!) of
aws/jsii#3085 and
#17120.

Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.

closes #16566
@njlynch njlynch requested a review from a team November 1, 2021 16:05
@njlynch njlynch self-assigned this Nov 1, 2021
@gitpod-io
Copy link

gitpod-io bot commented Nov 1, 2021

@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Nov 1, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 1, 2021
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Nov 1, 2021
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do-not-merge so I'm sure you get to see this.

Do we have launch day task (or pre-launch day task) that includes generating a final list of the deprecated APIs?

@njlynch
Copy link
Contributor Author

njlynch commented Nov 1, 2021

Do we have launch day task (or pre-launch day task) that includes generating a final list of the deprecated APIs?

Frankly, I'm considering the list generated in #17120 the final list. I'll send out a broader notice/announcement looking to see if anyone else has any last-minute deprecations that must get in.

@njlynch njlynch removed the pr/do-not-merge This PR should not be merged at this time. label Nov 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f24b9c8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d658525 into master Nov 1, 2021
@mergify mergify bot deleted the njlynch/v2-deprecated-list branch November 1, 2021 21:21
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
This is a continuation (and the final piece!) of aws/jsii#3085 and aws#17120.

Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.

closes aws#16566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CDKv2GA]: Support new @deprecations post-GA
4 participants