chore: bootstrap stack too old for integ tests #17277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integ tests try to be clever to save time, and rebootstrap an account and region pair only if the bootstrap stack does not exist yet. This is not good enough if the **version** of the bootstrap stack changes though (no rebootstrapping will happen), and the following error will occur: ``` ❌ cdktest-0n94n0po827f-test-2 failed: Error: cdktest-0n94n0po827f-test-2: This CDK deployment requires bootstrap stack version '6', found '4'. Please run 'cdk bootstrap'. ``` Instead, always bootstrap every account/region pair at least once per run. It will take some time, but in most cases we'll be able to short-circuit the CFN deployment, so it will take ~2s instead of ~20 per case.
|
|
rix0rrr
changed the title
|
After this has gone everywhere, we can revert https://github.com/cdklabs/cdk-ops/pull/1762 |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
added a commit
that referenced
this pull request
Nov 3, 2021
This is a follow-up to #17277: we switched to *always* bootstrapping the environment using the default settings, to automatically upgrade whenever an upgrade was available. However, if we run the integ test using a v1 CLI, the default bootstrap stack will be the legacy bootstrap, and we would actually be trying to *downgrade* it. Instead, always use the modern bootstrap stack. Since legacy apps can be deployed to the modern bootstrap stack, this is not an issue, and if a test actually needs the legacy stack to test something, it will explicitly try to create a fresh legacy bootstrap stack.
mergify bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
This is a follow-up to #17277: we switched to *always* bootstrapping the environment using the default settings, to automatically upgrade whenever an upgrade was available. However, if we run the integ test using a v1 CLI, the default bootstrap stack will be the legacy bootstrap, and we would actually be trying to *downgrade* it. Instead, always use the modern bootstrap stack. Since legacy apps can be deployed to the modern bootstrap stack, this is not an issue, and if a test actually needs the legacy stack to test something, it will explicitly try to create a fresh legacy bootstrap stack. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
The integ tests try to be clever to save time, and rebootstrap an account and region pair only if the bootstrap stack does not exist yet. This is not good enough if the **version** of the bootstrap stack changes though (no rebootstrapping will happen), and the following error will occur: ``` ❌ cdktest-0n94n0po827f-test-2 failed: Error: cdktest-0n94n0po827f-test-2: This CDK deployment requires bootstrap stack version '6', found '4'. Please run 'cdk bootstrap'. ``` Instead, always bootstrap every account/region pair at least once per run. It will take some time, but in most cases we'll be able to short-circuit the CFN deployment, so it will take ~2s instead of ~20 per case. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
This is a follow-up to aws#17277: we switched to *always* bootstrapping the environment using the default settings, to automatically upgrade whenever an upgrade was available. However, if we run the integ test using a v1 CLI, the default bootstrap stack will be the legacy bootstrap, and we would actually be trying to *downgrade* it. Instead, always use the modern bootstrap stack. Since legacy apps can be deployed to the modern bootstrap stack, this is not an issue, and if a test actually needs the legacy stack to test something, it will explicitly try to create a fresh legacy bootstrap stack. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integ tests try to be clever to save time, and rebootstrap an
account and region pair only if the bootstrap stack does not exist
yet.
This is not good enough if the version of the bootstrap stack
changes though (no rebootstrapping will happen), and the following
error will occur:
Instead, always bootstrap every account/region pair at least once
per run. It will take some time, but in most cases we'll be able to
short-circuit the CFN deployment, so it will take ~2s instead of
~20 per case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license