fix(cli): deprecated stack ids printed at the end of synth #19216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I still need to add unit tests for this |
otaviomacedo
approved these changes
Mar 3, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
approved these changes
Mar 4, 2022
TheRealAmazonKendra
pushed a commit
to TheRealAmazonKendra/aws-cdk
that referenced
this pull request
Mar 11, 2022
Using the regular stack identifier in cli commands is deprecated in v1, and removed in v2. If you supply the `.id` of a stack to any cdk commands (`synth`, `deploy`), then v1 will print out a deprecation warning. And, v2 will not work at all. Because of this, it is confusing to users that `cdk synth` prints out the regular stack identifier. It is best to print out the hierarchical identifier in all cases. At minimum, this partially fixes aws#18599. This will fix the scenario where the CLI prints out ``` Supply a stack id (StageOneF5E336C2, StageTwo81B557F6) to display its template. ``` when those ids will not actually work, and the hierarchical ids, `Stage/One` and `Stage/Two`, should be printed instead. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
One of the changes in #19216 is causing 3 unit tests in the CI environment of the pipeline to fail (for reasons not exactly clear). This changes unblocks them. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Mar 12, 2022
One of the changes in #19216 is causing 3 unit tests in the CI environment of the pipeline to fail (for reasons not exactly clear). This changes unblocks them. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit 4977ae5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the regular stack identifier in cli commands is deprecated in v1, and removed in v2. If you supply the
.idof a stack to any cdk commands (synth,deploy), then v1 will print out a deprecation warning. And, v2 will not work at all. Because of this, it is confusing to users thatcdk synthprints out the regular stack identifier. It is best to print out the hierarchical identifier in all cases.At minimum, this partially fixes #18599. This will fix the scenario where the CLI prints out
when those ids will not actually work, and the hierarchical ids,
Stage/OneandStage/Two, should be printed instead.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license