Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): fix test failing in CI #19362

Merged
merged 1 commit into from
Mar 11, 2022
Merged

chore(cli): fix test failing in CI #19362

merged 1 commit into from
Mar 11, 2022

Conversation

skinny85
Copy link
Contributor

One of the changes in #19216 is causing 3 unit tests in the CI environment of the pipeline to fail
(for reasons not exactly clear).
This changes unblocks them.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from madeline-k March 11, 2022 22:00
@gitpod-io
Copy link

gitpod-io bot commented Mar 11, 2022

@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Mar 11, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 11, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 897fd77
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4977ae5 into v2-main Mar 11, 2022
@mergify mergify bot deleted the fix-cli-test branch March 11, 2022 22:34
@skinny85
Copy link
Contributor Author

@Mergifyio backport to master

mergify bot pushed a commit that referenced this pull request Mar 12, 2022
One of the changes in #19216 is causing 3 unit tests in the CI environment of the pipeline to fail
(for reasons not exactly clear).
This changes unblocks them.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit 4977ae5)
@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2022

backport to master

✅ Backports have been created

mergify bot added a commit that referenced this pull request Mar 12, 2022
This is an automatic backport of pull request #19362 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants