Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kinesis): Read permissions to stream include kinesis:DescibeStreamConsumer #22727

Closed
wants to merge 0 commits into from

Conversation

watany-dev
Copy link
Contributor

@watany-dev watany-dev commented Nov 1, 2022

Grant Read(Write) Permission Action

  • "kinesis:DescribeStreamConsumer"

It appears that the following actions had already been added

  • "kinesis:SubscribeToShard",

ref. https://docs.aws.amazon.com/streams/latest/dev/tutorial-stock-data-kplkcl2-iam.html

Fixes #22184


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 1, 2022

@github-actions github-actions bot added the p2 label Nov 1, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team November 1, 2022 12:00
@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Nov 1, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@watany-dev watany-dev changed the title fix(kinesis): Read permissions to stream include kinesis:DescibeStreamConsumer chore(kinesis): Read permissions to stream include kinesis:DescibeStreamConsumer Nov 1, 2022
@github-actions github-actions bot added feature-request A feature should be added or improved. p1 and removed p2 labels Nov 1, 2022
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 1, 2022 12:22

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@Naumel
Copy link
Contributor

Naumel commented Nov 4, 2022

@watany-dev Mind fixing the conflicts before a proper review gets started?

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@watany-dev
Copy link
Contributor Author

watany-dev commented Nov 5, 2022

@Naumel
I was only looking at BUILD results, sorry. I will fix the conflicts them.

@watany-dev watany-dev closed this Nov 5, 2022
@watany-dev watany-dev force-pushed the 22184-kinesis-grant-add-read branch from a1302fc to dfcfb8d Compare November 5, 2022 02:20
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dfcfb8d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify bot pushed a commit that referenced this pull request Nov 25, 2022
…cribeStreamConsumer` (#22794)

reopen [22727](#22727)
 
Grant Read(Write) Permission Action

"kinesis:DescribeStreamConsumer"
It appears that the following actions had already been added

"kinesis:SubscribeToShard",
ref. https://docs.aws.amazon.com/streams/latest/dev/tutorial-stock-data-kplkcl2-iam.html

Fixes #22184

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-kinesis] Read permissions to stream don't include kinesis:DescribeStreamConsumer
3 participants