-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kinesis): read permissions for stream do not include kinesis:DescribeStreamConsumer
#22794
Conversation
The reason the build is failing is because Firehose's integ test depends on Kinesis. Subprocess exited with error 1
FAILED integ.delivery-stream.source-stream-integ.delivery-stream.source-stream (undefined/us-east-1) 8.534s
Integration test failed: Error: Command exited with status 1
Test Results:
Tests: 1 failed, 1 total
Error: Some integration tests failed!
at main (/workspace/aws-cdk/packages/@aws-cdk/integ-runner/lib/cli.js:105:23)
/workspace/aws-cdk/packages/@aws-cdk/core/lib/private/refs.js:146
throw e;
^
Error: Resolution error: Resolution error: Resolution error: Resolution error: Context value '@aws-cdk/core:target-partitions' should be a list of strings, got: "@aws-cdk/core:target-partitions". |
@Mergifyio update |
✅ Branch has been successfully updated |
This line is the issue
The permission needs to be added to the failing test. Re-run that test with |
Hmmm, kinesis* has been taken care of, but event-target. I guess I still have to go through the full build integ |
The integ test seems to have passed successfully |
@Mergifyio update |
✅ Branch has been successfully updated |
kinesis:DescribeStreamConsumer
kinesis:DescribeStreamConsumer
kinesis:DescribeStreamConsumer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
Added |
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
reopen 22727
Grant Read(Write) Permission Action
"kinesis:DescribeStreamConsumer"
It appears that the following actions had already been added
"kinesis:SubscribeToShard",
ref. https://docs.aws.amazon.com/streams/latest/dev/tutorial-stock-data-kplkcl2-iam.html
Fixes #22184
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license