Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kinesis): read permissions for stream do not include kinesis:DescribeStreamConsumer #22794

Merged
merged 8 commits into from
Nov 25, 2022

Conversation

watany-dev
Copy link
Contributor

@watany-dev watany-dev commented Nov 5, 2022

reopen 22727

Grant Read(Write) Permission Action

"kinesis:DescribeStreamConsumer"
It appears that the following actions had already been added

"kinesis:SubscribeToShard",
ref. https://docs.aws.amazon.com/streams/latest/dev/tutorial-stock-data-kplkcl2-iam.html

Fixes #22184


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 5, 2022

@github-actions github-actions bot added feature-request A feature should be added or improved. p1 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Nov 5, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team November 5, 2022 06:56
@watany-dev
Copy link
Contributor Author

The reason the build is failing is because Firehose's integ test depends on Kinesis.
I have attempted to resolve this, but am getting an obscure error and am having trouble parsing it.

Subprocess exited with error 1
  FAILED     integ.delivery-stream.source-stream-integ.delivery-stream.source-stream (undefined/us-east-1) 8.534s
      Integration test failed: Error: Command exited with status 1

Test Results: 

Tests:    1 failed, 1 total
Error: Some integration tests failed!
    at main (/workspace/aws-cdk/packages/@aws-cdk/integ-runner/lib/cli.js:105:23)
/workspace/aws-cdk/packages/@aws-cdk/core/lib/private/refs.js:146
            throw e;
            ^

Error: Resolution error: Resolution error: Resolution error: Resolution error: Context value '@aws-cdk/core:target-partitions' should be a list of strings, got: "@aws-cdk/core:target-partitions".

@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2022

update

✅ Branch has been successfully updated

@TheRealAmazonKendra
Copy link
Contributor

This line is the issue

@aws-cdk/aws-kinesisfirehose:             [+]     "kinesis:DescribeStreamConsumer",

The permission needs to be added to the failing test. Re-run that test with --update-on-failed.

@watany-dev
Copy link
Contributor Author

Hmmm, kinesis* has been taken care of, but event-target. I guess I still have to go through the full build integ

@watany-dev
Copy link
Contributor Author

The integ test seems to have passed successfully

@mrgrain
Copy link
Contributor

mrgrain commented Nov 25, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

update

✅ Branch has been successfully updated

@mrgrain mrgrain changed the title chore(kinesis): Read permissions to stream include kinesis:DescibeStreamConsumer fix(kinesis): read permissions to stream do not include kinesis:DescribeStreamConsumer Nov 25, 2022
@mrgrain mrgrain changed the title fix(kinesis): read permissions to stream do not include kinesis:DescribeStreamConsumer fix(kinesis): read permissions for stream do not include kinesis:DescribeStreamConsumer Nov 25, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 25, 2022
@mrgrain
Copy link
Contributor

mrgrain commented Nov 25, 2022

Added pr-linter/exempt-integ-test since integ tests are updated and a change to a test case is not required here.

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 25, 2022 16:36

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a86ee31
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e53352d into aws:main Nov 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@watany-dev watany-dev deleted the 22184-r2 branch November 26, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK feature-request A feature should be added or improved. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-kinesis] Read permissions to stream don't include kinesis:DescribeStreamConsumer
4 participants