chore(cli): show a warning on a platform with a known bug #23076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A particular combination of software has hard-to-recover bug. Add a check and warning for it. Closes #21379.
|
|
rix0rrr
added
the
pr-linter/exempt-integ-test
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Nov 24, 2022
aws-cdk-automation
previously requested changes
Nov 24, 2022
rix0rrr
added
the
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
corymhall
suggested changes
Nov 29, 2022
packages/aws-cdk/lib/cli.ts
Outdated
| @@ -294,6 +295,9 @@ async function initCommandLine() { | |||
| if (argv.ci) { | |||
| setCI(true); | |||
| } | |||
|
|
|||
| await checkForPlatformWarnings(); | |||
There was a problem hiding this comment.
Should we catch any errors and just proceed?
There was a problem hiding this comment.
Shouldn't happen, but sure. Sounds safe.
Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>
corymhall
approved these changes
Dec 1, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Dec 9, 2022
A particular combination of software has hard-to-diagnose bug. Add a check and warning for it. Closes aws#21379. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Jan 20, 2023
A particular combination of software has hard-to-diagnose bug. Add a check and warning for it. Closes aws#21379. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Feb 22, 2023
A particular combination of software has hard-to-diagnose bug. Add a check and warning for it. Closes aws#21379. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A particular combination of software has hard-to-diagnose bug.
Add a check and warning for it.
Closes #21379.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license