Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): show a warning on a platform with a known bug #23076

Merged
merged 5 commits into from
Dec 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/aws-cdk/lib/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import { Command, Configuration, Settings } from '../lib/settings';
import * as version from '../lib/version';
import { DeploymentMethod } from './api';
import { enableTracing } from './util/tracing';
import { checkForPlatformWarnings } from './platform-warnings';

// https://github.com/yargs/yargs/issues/1929
// https://github.com/evanw/esbuild/issues/1492
Expand Down Expand Up @@ -294,6 +295,13 @@ async function initCommandLine() {
if (argv.ci) {
setCI(true);
}

try {
await checkForPlatformWarnings();
} catch (e) {
debug(`Error while checking for platform warnings: ${e}`);
}

debug('CDK toolkit version:', version.DISPLAY_VERSION);
debug('Command line arguments:', argv);

Expand Down
41 changes: 41 additions & 0 deletions packages/aws-cdk/lib/platform-warnings.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import * as os from 'os';
import * as logging from './logging';
import * as fs from 'fs-extra';

export async function checkForPlatformWarnings() {
if (await hasDockerCopyBug()) {
logging.warning('`cdk synth` may hang in Docker on Linux 5.6-5.10. See https://github.com/aws/aws-cdk/issues/21379 for workarounds.');
}
}

async function hasDockerCopyBug() {
return await runningInDocker() && os.platform() === 'linux' && isVersionBetween(os.release(), '5.6', '5.10');
}

async function runningInDocker() {
return fs.pathExists('/.dockerenv');
}

export function isVersionBetween(version: string, lower: string, upper: string) {
const ver = splitVersion(version);
const lo = splitVersion(lower);
const up = splitVersion(upper);

while (lo.length < ver.length) { lo.push(0); }
while (up.length < ver.length) { up.push(9999999); }

let n = ver.length;
for (let i = 0; i < n; i++) {
if (lo[i] < ver[i] && ver[i] < up[i]) { return true; }
if (lo[i] > ver[i] || ver[i] > up[i]) { return false; }
}

return false;

}

function splitVersion(version: string): number[] {
return `${version}`.split('.')
.map(x => parseInt(x, 10))
.map(x => isNaN(x) ? 0 : x);
}
15 changes: 15 additions & 0 deletions packages/aws-cdk/test/platform-warnings.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { isVersionBetween } from '../lib/platform-warnings';


test.each([
['2.1', false],
['2.2', true],
['2', false],
['3', true],
['4', false],
['4.3', true],
['4.3', true],
['4.2.294-220.533.amzn2.x86_64', true],
])('%p is in range: %p', (version, expected) => {
expect(isVersionBetween(version, '2.1.0.6', '4.9.2')).toEqual(expected);
});