Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imports from ESM modules cannot find correct type definitions #23870

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jan 27, 2023

With #23813 and #23846 we have introduced a new, dedicated export for use in ESM modules. The generated type definitions for this ESM export entry point do not contain the correct types. This is expected, however when TypeScript attempts to use the ESM export, it will fail due to the lack of type definitions.

This change explicitly sets the type definitions for the top-level export to index.d.ts which contains the correct type definitions for all exports, no matter if they are CJS or ESM.


All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 27, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team January 27, 2023 10:30
@github-actions github-actions bot added the p2 label Jan 27, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 27, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jan 27, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 27, 2023 10:32

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 13123b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr merged commit 356a128 into main Jan 27, 2023
@rix0rrr rix0rrr deleted the mrgrain/fix/esm-import-types branch January 27, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants