Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imports from ESM modules cannot find correct type definitions #23870

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix: imports from ESM modules cannot find correct type definitions #23870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/aws-cdk-lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@
},
"exports": {
".": {
"types": "./index.d.ts",
"import": "./index.js",
"require": "./lazy-index.js"
},
Expand Down
2 changes: 2 additions & 0 deletions tools/@aws-cdk/ubergen/bin/ubergen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ interface LibraryReference {
}

type Export = string | {
readonly types?: string;
readonly import?: string;
readonly require?: string;
};
Expand Down Expand Up @@ -275,6 +276,7 @@ async function prepareSourceFiles(libraries: readonly LibraryReference[], packag
// allowed for this package: we only want to allow the exact import statements that we want to support.
packageJson.exports = {
'.': {
types: './index.d.ts',
import: './index.js',
require: './lazy-index.js',
},
Expand Down