fix(lambda-nodejs): pnpm no longer supports nodejs14.x #24821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing a couple of things - Update `Dockerfile` image to nodejs18 - Pin pnpm to 8.0.0 (latest version) - Add some error handling to the test to better catch this error in the future
otaviomacedo
approved these changes
Mar 28, 2023
aws-cdk-automation
previously requested changes
Mar 28, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
corymhall
added a commit
that referenced
this pull request
Mar 28, 2023
Doing a couple of things - Update `Dockerfile` image to nodejs18 - Pin pnpm to 8.0.0 (latest version) - Add some error handling to the test to better catch this error in the future ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
corymhall
added a commit
that referenced
this pull request
Mar 28, 2023
Doing a couple of things - Update `Dockerfile` image to nodejs18 - Pin pnpm to 8.0.0 (latest version) - Add some error handling to the test to better catch this error in the future ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
@Mergifyio backport v1-main |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
Doing a couple of things - Update `Dockerfile` image to nodejs18 - Pin pnpm to 8.0.0 (latest version) - Add some error handling to the test to better catch this error in the future ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit b1c9ab2) # Conflicts: # packages/@aws-cdk/aws-lambda-destinations/test/destinations.integ.snapshot/asset.1bc7cf3a01a7153f942391263b3bac937812996cc28f9abaf83ffebbbe03e38b.bundle/index.js # packages/@aws-cdk/aws-lambda-nodejs/test/compilations.integ.snapshot/integ.json # packages/@aws-cdk/aws-lambda-nodejs/test/compilations.integ.snapshot/tree.json # packages/@aws-cdk/aws-lambda-nodejs/test/dependencies.integ.snapshot/asset.9ea9c0b2e771d6d3cf404fc942748e905e9680505b2b07f5fa83e13d5d6490d3/node_modules/.yarn-integrity # packages/@aws-cdk/aws-lambda-nodejs/test/dependencies.integ.snapshot/asset.9ea9c0b2e771d6d3cf404fc942748e905e9680505b2b07f5fa83e13d5d6490d3/node_modules/delay/index.d.ts # packages/@aws-cdk/aws-lambda-nodejs/test/dependencies.integ.snapshot/asset.9ea9c0b2e771d6d3cf404fc942748e905e9680505b2b07f5fa83e13d5d6490d3/node_modules/delay/index.js # packages/@aws-cdk/aws-lambda-nodejs/test/dependencies.integ.snapshot/asset.9ea9c0b2e771d6d3cf404fc942748e905e9680505b2b07f5fa83e13d5d6490d3/node_modules/delay/license # packages/@aws-cdk/aws-lambda-nodejs/test/dependencies.integ.snapshot/asset.9ea9c0b2e771d6d3cf404fc942748e905e9680505b2b07f5fa83e13d5d6490d3/node_modules/delay/package.json # packages/@aws-cdk/aws-lambda-nodejs/test/dependencies.integ.snapshot/asset.9ea9c0b2e771d6d3cf404fc942748e905e9680505b2b07f5fa83e13d5d6490d3/node_modules/delay/readme.md # packages/@aws-cdk/aws-lambda-nodejs/test/dependencies.integ.snapshot/asset.9ea9c0b2e771d6d3cf404fc942748e905e9680505b2b07f5fa83e13d5d6490d3/package.json # packages/@aws-cdk/aws-lambda-nodejs/test/dependencies.integ.snapshot/asset.9ea9c0b2e771d6d3cf404fc942748e905e9680505b2b07f5fa83e13d5d6490d3/yarn.lock # packages/@aws-cdk/aws-lambda-nodejs/test/docker.test.ts # packages/@aws-cdk/aws-lambda-nodejs/test/integ.compilations.js.snapshot/cdk-integ-compilations-lambda-nodejs.template.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.compilations.js.snapshot/manifest.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies-pnpm.js.snapshot/TestStack.template.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies-pnpm.js.snapshot/asset.92ec9d050245fd270cf2b0df478b31f140ba820c3407e964246946bcea933a19.bundle/index.js # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies-pnpm.js.snapshot/cdk.out # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies-pnpm.js.snapshot/integ.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies-pnpm.js.snapshot/manifest.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies-pnpm.js.snapshot/tree.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/LambdaDependenciesDefaultTestDeployAssert259C940B.assets.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/LambdaDependenciesDefaultTestDeployAssert259C940B.template.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.50a8879346510e33e69a511e29d588e7b2d2b477b6989a4db677027bb8605b9f/index.js # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.50a8879346510e33e69a511e29d588e7b2d2b477b6989a4db677027bb8605b9f/node_modules/.yarn-integrity # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.50a8879346510e33e69a511e29d588e7b2d2b477b6989a4db677027bb8605b9f/node_modules/delay/index.d.ts # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.50a8879346510e33e69a511e29d588e7b2d2b477b6989a4db677027bb8605b9f/node_modules/delay/index.js # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.50a8879346510e33e69a511e29d588e7b2d2b477b6989a4db677027bb8605b9f/node_modules/delay/license # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.50a8879346510e33e69a511e29d588e7b2d2b477b6989a4db677027bb8605b9f/node_modules/delay/package.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.50a8879346510e33e69a511e29d588e7b2d2b477b6989a4db677027bb8605b9f/node_modules/delay/readme.md # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.50a8879346510e33e69a511e29d588e7b2d2b477b6989a4db677027bb8605b9f/package.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.50a8879346510e33e69a511e29d588e7b2d2b477b6989a4db677027bb8605b9f/yarn.lock # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.92ec9d050245fd270cf2b0df478b31f140ba820c3407e964246946bcea933a19.bundle/index.js # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.b54b99043c35bd080b9d9d1afce31e3541cf15b679799ba980ed40c837dcb03b.bundle/index.js # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.f078d47ca35d3ee8cf531975a21ac17857ee7d4afc2c1a5a01ccc8b597b9ba88/node_modules/.yarn-integrity # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.f078d47ca35d3ee8cf531975a21ac17857ee7d4afc2c1a5a01ccc8b597b9ba88/node_modules/delay/index.d.ts # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.f078d47ca35d3ee8cf531975a21ac17857ee7d4afc2c1a5a01ccc8b597b9ba88/node_modules/delay/index.js # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.f078d47ca35d3ee8cf531975a21ac17857ee7d4afc2c1a5a01ccc8b597b9ba88/node_modules/delay/license # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.f078d47ca35d3ee8cf531975a21ac17857ee7d4afc2c1a5a01ccc8b597b9ba88/node_modules/delay/package.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.f078d47ca35d3ee8cf531975a21ac17857ee7d4afc2c1a5a01ccc8b597b9ba88/node_modules/delay/readme.md # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.f078d47ca35d3ee8cf531975a21ac17857ee7d4afc2c1a5a01ccc8b597b9ba88/package.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/asset.f078d47ca35d3ee8cf531975a21ac17857ee7d4afc2c1a5a01ccc8b597b9ba88/yarn.lock # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/cdk-integ-lambda-nodejs-dependencies-for-sdk-v3.assets.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/cdk-integ-lambda-nodejs-dependencies.template.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/cdk.out # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/integ.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/manifest.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.js.snapshot/tree.json # packages/@aws-cdk/aws-lambda-nodejs/test/integ.dependencies.ts # packages/@aws-cdk/aws-lambda/test/bundling.integ.snapshot/BundlingDefaultTestDeployAssertAACA0CAF.template.json # packages/@aws-cdk/pipelines/test/pipeline-with-assets-single-upload.integ.snapshot/PipelineStack.assets.json # packages/@aws-cdk/pipelines/test/pipeline-with-assets.integ.snapshot/PipelineStack.assets.json # packages/@aws-cdk/pipelines/test/pipeline-with-variables.integ.snapshot/VariablePipelineStack.assets.json # packages/@aws-cdk/pipelines/test/pipeline.integ.snapshot/PipelineStack.assets.json
corymhall
added a commit
that referenced
this pull request
Mar 28, 2023
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
…) (#24829) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
HBobertz
pushed a commit
that referenced
this pull request
Mar 28, 2023
…) (#24829) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Mar 28, 2023
Doing a couple of things - Update `Dockerfile` image to nodejs18 - Pin pnpm to 8.0.0 (latest version) - Add some error handling to the test to better catch this error in the future ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 31, 2023
|
FYI, this PR is partially related to causing the following issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a couple of things
Dockerfileimage to nodejs18By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license