fix(route53): timeouts due to delete-existing-record-set-handler's wait time

[pistazie]

This PR updates the wait time of the delete-existing-record-set-handler from 60 to 1800 seconds.

Commit 399b6bb upgraded the handler to use the AWS SDK V3 (was V2) and made the following change:

-  await route53.waitFor('resourceRecordSetsChanged', { Id: changeResourceRecordSets.ChangeInfo.Id }).promise();
+  await waitUntilResourceRecordSetsChanged({ client: route53, maxWaitTime: 60 }, { Id: changeResourceRecordSets?.ChangeInfo?.Id })

The V2 route53.waitFor waits for 1800 seconds (see reference)

Waits for the resourceRecordSetsChanged state by periodically calling the underlying [Route53.getChange()](https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Route53.html#getChange-property) operation every 30 seconds (at most 60 times).

The new explicit configuration was set to 60 seconds which is too short and caused timeouts and failure in our cloudformation stacks

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[kaizencc]

hi @pistazie I went to update the snapshot for you but it looks like I don't have permissions to update to the pitch-io fork.

Instead, I've created #27068. If you want, you can update the snapshot on this PR before the other one is merged and we'll go with yours. Otherwise, I'll add you as a collaborator on the other PR and get it in asap.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[pistazie]

hi @pistazie I went to update the snapshot for you but it looks like I don't have permissions to update to the pitch-io fork.

Instead, I've created #27068. If you want, you can update the snapshot on this PR before the other one is merged and we'll go with yours. Otherwise, I'll add you as a collaborator on the other PR and get it in asap.

thanks for picking this up @kaizencc . Would love to be a contributor. also fixed snapshots (hopefully well)

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 663637f
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[kaizencc]

@pistazie

#27068 (comment)

Are you down to move the timeout to 890? the custom resource lambda times out after 15 minutes, which is the max.

To update the integ test real fast you can run yarn integ test/aws-route53/test/integ.delete-existing-record-set.js --update-on-failed --dry-run

[kaizencc]

fyi I went and called out this exact scenario in #27072. Basically, its really tough for us to accept contributions without allowing commits to your branch, since not only does that mean I can't do it but neither can our automation that syncs with main. In short, to accept contributions we need contributors to develop on a fork in their own personal account (the issue here), and not on their fork's main branch.

Going to close this over the other one for this exact reason, but thank you for the contribution and highlighting a nasty bug in our custom resource.