Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route53): timeouts due to delete-existing-record-set-handler's wait time #27060

Closed
wants to merge 2 commits into from
Closed

fix(route53): timeouts due to delete-existing-record-set-handler's wait time #27060

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c7f8e
Updates delete-existing-record-set-handler maxWaitTime to 30 * 60 sec…
pistazie Sep 8, 2023
663637f
updates snapshots
pistazie Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-route53/lib/delete-existing-record-set-handler/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export async function handler(event: AWSLambda.CloudFormationCustomResourceEvent
},
});

await waitUntilResourceRecordSetsChanged({ client: route53, maxWaitTime: 60 }, { Id: changeResourceRecordSets?.ChangeInfo?.Id });
await waitUntilResourceRecordSetsChanged({ client: route53, maxWaitTime: 1800 }, { Id: changeResourceRecordSets?.ChangeInfo?.Id });

return {
PhysicalResourceId: `${existingRecord.Name}-${existingRecord.Type}`,
Expand Down
Loading