-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(custom_resources): Provider Lambda function is missing lambda:GetFunctionConfiguration permission #27204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: integration tests do not exist for the custom_resources module |
Hello, the custom resource integ tests live here https://github.com/aws/aws-cdk/tree/main/packages/%40aws-cdk-testing/framework-integ/test/custom-resources/test. Additionally, we will not be able to provide a meaningful review until the build is passing. |
Hey, I see you have opened the PR from |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Exemption request: We can't really integ test this as it would require a lambda function that was already inactive (20 minute wait time) and we don't have that resource setup. |
That is fine, we can run the test for you. But the build is failing right now and we cannot prioritize a review for this PR till that is fixed. Let us know if we can assist with anything. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR solves the problem of missing permissions for lambda created with the provider framework.
We found this issue in the landing zone accelerator solution that leverages the custom_resources module. Related issue.
Closes #26838.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license