Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat(core): Schedule class" #27284

Merged
merged 5 commits into from
Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions allowed-breaking-changes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -191,3 +191,38 @@ removed:aws-cdk-lib.aws_ec2.CfnNetworkInterfaceProps.enablePrimaryIpv6

# Changed type from GraphqlApi to IGraphqlApi to support import from a different stack, should not matter.
weakened:aws-cdk-lib.aws_appsync.SourceApi

# Due to https://github.com/aws/aws-cdk/issues/27259, none of these could have worked
# When reimplemented, we can remove this entry entirely
removed:aws-cdk-lib.Schedule
removed:aws-cdk-lib.aws_backup.Schedule
removed:aws-cdk-lib.CronOptions
base-types:aws-cdk-lib.aws_applicationautoscaling.Schedule
removed:aws-cdk-lib.aws_applicationautoscaling.Schedule.protectedAt
removed:aws-cdk-lib.aws_applicationautoscaling.Schedule.protectedCron
removed:aws-cdk-lib.aws_applicationautoscaling.Schedule.protectedExpression
removed:aws-cdk-lib.aws_applicationautoscaling.Schedule.protectedRate
removed-argument:aws-cdk-lib.aws_applicationautoscaling.Schedule.at
incompatible-argument:aws-cdk-lib.aws_applicationautoscaling.Schedule.cron
removed-argument:aws-cdk-lib.aws_applicationautoscaling.Schedule.expression
removed:aws-cdk-lib.aws_applicationautoscaling.Schedule.timeZone
base-types:aws-cdk-lib.aws_autoscaling.Schedule
removed:aws-cdk-lib.aws_autoscaling.Schedule.protectedAt
removed:aws-cdk-lib.aws_autoscaling.Schedule.protectedCron
removed:aws-cdk-lib.aws_autoscaling.Schedule.protectedExpression
removed:aws-cdk-lib.aws_autoscaling.Schedule.protectedRate
incompatible-argument:aws-cdk-lib.aws_autoscaling.Schedule.cron
removed-argument:aws-cdk-lib.aws_autoscaling.Schedule.expression
removed:aws-cdk-lib.aws_autoscaling.Schedule.timeZone
base-types:aws-cdk-lib.aws_events.Schedule
removed:aws-cdk-lib.aws_events.Schedule.protectedAt
removed:aws-cdk-lib.aws_events.Schedule.protectedCron
removed:aws-cdk-lib.aws_events.Schedule.protectedExpression
removed:aws-cdk-lib.aws_events.Schedule.protectedRate
removed:aws-cdk-lib.aws_events.Schedule.timeZone
base-types:aws-cdk-lib.aws_applicationautoscaling.CronOptions
removed:aws-cdk-lib.aws_applicationautoscaling.CronOptions.timeZone
base-types:aws-cdk-lib.aws_autoscaling.CronOptions
removed:aws-cdk-lib.aws_autoscaling.CronOptions.timeZone
removed:aws-cdk-lib.aws_autoscaling.CronOptions.year
removed:aws-cdk-lib.aws_backup.BackupPlanRuleProps.schedule

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
},
"RuleName": "Daily",
"ScheduleExpression": "cron(0 5 * * ? *)",
"ScheduleExpressionTimezone": "Etc/UTC",
"TargetBackupVault": {
"Fn::GetAtt": [
"Vault23237E5B",
Expand All @@ -97,7 +96,6 @@
},
"RuleName": "Weekly",
"ScheduleExpression": "cron(0 5 ? * SAT *)",
"ScheduleExpressionTimezone": "Etc/UTC",
"TargetBackupVault": {
"Fn::GetAtt": [
"Vault23237E5B",
Expand All @@ -112,7 +110,6 @@
},
"RuleName": "Monthly5Year",
"ScheduleExpression": "cron(0 5 1 * ? *)",
"ScheduleExpressionTimezone": "Etc/UTC",
"TargetBackupVault": {
"Fn::GetAtt": [
"Vault23237E5B",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading