Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "feat(core): Schedule class" #27284

Merged
merged 5 commits into from
Sep 25, 2023
Merged

revert: "feat(core): Schedule class" #27284

merged 5 commits into from
Sep 25, 2023

Conversation

kaizencc
Copy link
Contributor

Reverts #27105

This fixes #27259 by reverting the offending commit.

@aws-cdk-automation aws-cdk-automation requested a review from a team September 25, 2023 19:25
@github-actions github-actions bot added bug This issue is a bug. p0 labels Sep 25, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 25, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: af14a67
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 252d9ba into main Sep 25, 2023
14 checks passed
@mergify mergify bot deleted the revert-27105-conroy/schedulecore branch September 25, 2023 22:45
kaizencc added a commit that referenced this pull request Sep 25, 2023
@kaizencc
revert: "feat(core): Schedule class" (#27284)
e2fc724 
Reverts #27105

This fixes #27259 by reverting the offending commit.
This was referenced Sep 26, 2023
Closed
Merged
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
@kaizencc kaizencc mentioned this pull request Oct 2, 2023
Closed
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
@go-to-k
test(autoscaling): add tests for Schedule.cron specifying with either…
7398f0c 
… day or weekday (#27296)

I was trying to fix [this bug](#27256), but [this revert PR](#27284) could cover it.

So I added the test cases for the bug fix.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrArnoldPalmer MrArnoldPalmer MrArnoldPalmer approved these changes

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p0
Projects
None yet
Milestone
No milestone
3 participants
@kaizencc @aws-cdk-automation @MrArnoldPalmer