Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(autoscaling): add tests for Schedule.cron specifying with either day or weekday #27296

Merged
merged 7 commits into from
Oct 18, 2023
Merged

test(autoscaling): add tests for Schedule.cron specifying with either day or weekday #27296

merged 7 commits into from
Oct 18, 2023

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Sep 26, 2023 •
edited
Loading

I was trying to fix this bug, but this revert PR could cover it.

So I added the test cases for the bug fix.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Sep 26, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 26, 2023 15:23
@github-actions github-actions bot added the p2 label Sep 26, 2023
@go-to-k go-to-k marked this pull request as ready for review September 26, 2023 15:28
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 26, 2023
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
lpizzinidev
lpizzinidev approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 9, 2023
@TheRealAmazonKendra
Copy link
Contributor

A PR just adding test cases? Yesssssss!

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k
Copy link
Contributor Author

go-to-k commented Oct 13, 2023 •
edited
Loading

@TheRealAmazonKendra

Queue: Embarked in merge queue was failed. Could you handle this?

@scanlonp
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review October 16, 2023 20:33

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 16, 2023
vinayak-kukreja
vinayak-kukreja approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Apologies for the delay in merging this PR.

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8d6d519
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7398f0c into aws:main Oct 18, 2023
10 checks passed
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k go-to-k deleted the fix/aws-autoscaling-day-weekday branch June 28, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@vinayak-kukreja vinayak-kukreja vinayak-kukreja approved these changes

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra left review comments

Assignees
No one assigned
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-autoscaling: Schedule.cron fails with "Cannot supply both 'day' and 'weekDay', use at most one"
6 participants
@go-to-k @TheRealAmazonKendra @scanlonp @aws-cdk-automation @lpizzinidev @vinayak-kukreja