-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): support Fn::ImportValue
intrinsic function for hotswap deployments
#27292
feat(cli): support Fn::ImportValue
intrinsic function for hotswap deployments
#27292
Conversation
Fn::ImportValue
intrinsic function for hotswap deployments
0a78d8a
to
ecdd7c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
I've reviewed the integration tests for |
I'm not certain on how to action this one -- could someone help me get this linter request resolved? |
2b5af44
to
97784ab
Compare
97784ab
to
c0d8620
Compare
Have rebased to tip of |
b9d9c7c
to
12e9c6a
Compare
@vinayak-kukreja added the doco link and rebased to tip of |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Fn::ImportValue
intrinsic function for hotswap deploymentsFn::ImportValue
intrinsic function for hotswap deployments
Hey @tomwwright , the PR looks good to me. Running it through our test pipeline again with the merge from main. Will approve the PR if the workflow passes. |
Hey apologies for the delay. We are facing some issues with our test pipeline. I will update here as I get a chance to run this PR through the pipeline. |
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tomwwright , the pipeline run was successful. Thank you for contributing to the cdk. Really appreciate your effort.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for your review @vinayak-kukreja 🙌 |
Purpose 🎯
Extend the
EvaluateCloudFormationTemplate
class to support theFn::ImportValue
intrinsic function. This allows for more diverse templates to be evaluated for the purposes of determining eligibility for--hotswap
deploymentsCloses #21320
Approach 🧠
Implement
LazyLookupExport
in similar fashion toLazyListStackResources
to cache required CloudFormation API calls (preference was to implement using a generator function instead so style is not entirely consistent, is this an issue?)Add some basic unit tests for
EvaluateCloudFormationTemplate.evaluateCfnExpression()
is they were absent, then add some tests forFn::ImportValue
Todo 📝
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license