Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): support Fn::ImportValue intrinsic function for hotswap deployments #27292

Merged
merged 25 commits into from
Oct 19, 2023
Merged

feat(cli): support Fn::ImportValue intrinsic function for hotswap deployments #27292

merged 25 commits into from
Oct 19, 2023

Commits on Oct 17, 2023

  1. test: basic units for EvaluateCloudFormationTemplate

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    6c25649 View commit details
    Browse the repository at this point in the history

  2. test: add basic literal expression evaluation tests

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1958df1 View commit details
    Browse the repository at this point in the history

  3. feat: LazyLookupExport class

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    599ba98 View commit details
    Browse the repository at this point in the history

  4. fix: typo in filename

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    8f9443e View commit details
    Browse the repository at this point in the history

  5. test: tdd for importvalue resolver

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a48f8c7 View commit details
    Browse the repository at this point in the history

  6. feat: resolve Fn::ImportValue

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b1c4cda View commit details
    Browse the repository at this point in the history

  7. refactor: undefined instead of throw when export not found

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    14681d1 View commit details
    Browse the repository at this point in the history

  8. style: remove unused import

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    01f278a View commit details
    Browse the repository at this point in the history

  9. fix: pass new lookup in other usages

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4ac2b6e View commit details
    Browse the repository at this point in the history

  10. test: add Fn::ImportValue resolution test

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3e3bb12 View commit details
    Browse the repository at this point in the history

  11. docs: add clarifying note on intrinsic function support for hotswaps

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a4828ac View commit details
    Browse the repository at this point in the history

  12. refactor: unroll internal to generator 

    refactor: improve variable naming
    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    e570c15 View commit details
    Browse the repository at this point in the history

  13. refactor: more descriptive variable name

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1498d17 View commit details
    Browse the repository at this point in the history

  14. refactor: tighter variable scoping 

    note that without the type def it falls back to 'any'

'response' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.ts(7022)
    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d9b5c4c View commit details
    Browse the repository at this point in the history

  15. docs: qualify partal support for fn::getatt

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d93f78b View commit details
    Browse the repository at this point in the history

  16. refactor: rely on abstraction not implementation 

    no need for this property to be the concretion
    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    97e7563 View commit details
    Browse the repository at this point in the history

  17. refactor: lookupExport into an internal concern 

    fix: update broken test from rebase
    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    6fcb17c View commit details
    Browse the repository at this point in the history

  18. fix: remove unused import

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    72e594d View commit details
    Browse the repository at this point in the history

  19. docs: remove code link to be more suitable for user-facing doco

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    96e2602 View commit details
    Browse the repository at this point in the history

  20. test: add integration test for hotswap support

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    7eb4d78 View commit details
    Browse the repository at this point in the history

  21. fix: silently skip listed exports without name

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9d9c4af View commit details
    Browse the repository at this point in the history

  22. docs: add link to qualify fn::getatt limitations

    @tomwwright
    tomwwright committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    12e9c6a View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge branch 'main' into tomwwright/support-fn-importvalue-in-evaluate

    @vinayak-kukreja
    vinayak-kukreja committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    d5b5361 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge branch 'main' into tomwwright/support-fn-importvalue-in-evaluate

    @vinayak-kukreja
    vinayak-kukreja committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f5c30dc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tomwwright/support-fn-importvalue-in-evaluate

    @mergify
    mergify[bot] committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    79cb2c7 View commit details
    Browse the repository at this point in the history