Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glue-alpha): adding partition projection #27447

Closed
wants to merge 6 commits into from
Closed

Conversation

guyernest
Copy link

The partition projection feature in Athena and Glue was not supported correctly in the S3Table implementation. The table properties from the partition project were not added to the Parameters section of TableInput.

The new implementation allows the definition of the different types of partition projection, including date, integer and enum,

Closes #27365


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 9, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 9, 2023 04:40
@github-actions github-actions bot added bug This issue is a bug. p2 labels Oct 9, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@guyernest guyernest changed the title feat(aws-glue-alpha): adding partition projection feat(glue-alpha): adding partition projection Oct 9, 2023
@guyernest
Copy link
Author

Exemption Request

The change is internal to S3-Table and doesn't affect other modules and no integration tests are needed (IMHO).

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 9, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 10, 2023 18:53

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@guyernest guyernest closed this Oct 10, 2023
@guyernest
Copy link
Author

Adding integration test and PR again

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

⚠️ The sha of the head commit of this PR conflicts with #27485. Mergify cannot evaluate rules on this PR. ⚠️

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 070ac51
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-glue-alpha: S3-Table table properties are added to the wrong parameters section
2 participants