feat(glue-alpha): adding partition projection #27485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
beginning-contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
scanlonp
requested changes
Oct 11, 2023
There was a problem hiding this comment.
Thank you for the contribution! A couple comments.
First, we require that pulls are made from non-main branches on your fork (see https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request for more info). Please move this on to a different branch.
Removing the unused variable names in the tests should fix the immediate errors in the build. Then we can give a meaningful review.
| DateIntervalUnit.DAYS, | ||
| ); | ||
|
|
||
| const table = new glue.S3Table(stack, 'Table', { |
There was a problem hiding this comment.
Suggested change
| const table = new glue.S3Table(stack, 'Table', { | |
| new glue.S3Table(stack, 'Table', { |
| DateIntervalUnit.DAYS, | ||
| ); | ||
|
|
||
| const table = new glue.S3Table(stack, 'Table', { |
There was a problem hiding this comment.
Suggested change
| const table = new glue.S3Table(stack, 'Table', { | |
| new glue.S3Table(stack, 'Table', { |
|
Cleaning and opening a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partition projection feature in Athena and Glue needed to be supported correctly in the S3Table implementation. The table properties from the partition project were not added to the Parameters section of TableInput.
The new implementation allows the definition of the different types of partition projection, including date, integer and enum,
Closes #27365
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license