Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ec2): naming collisions when using ec2.InitFile.fromAsset() on multiple instances in the same stack #27468

Merged
merged 17 commits into from
Oct 23, 2023
Merged

fix(ec2): naming collisions when using ec2.InitFile.fromAsset() on multiple instances in the same stack #27468

merged 17 commits into from
Oct 23, 2023

Commits on Oct 6, 2023

  1. add first test case from issue repro code 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b9a7e9f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. add md5hash(bindOptions.scope.node.id) to s3 asset name, but test is … 

    …still failing

Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c30f22b View commit details
    Browse the repository at this point in the history

  2. change bind id hash to hash of md5hash(bindOptions.scope.node.childre… 

    …n.toString()) -- test now passes successfully

Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c19797a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @sumupitchayan
    sumupitchayan authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9ec3c62 View commit details
    Browse the repository at this point in the history

  4. write initial integ test and create snapshots 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f0fbafd View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @sumupitchayan
    sumupitchayan authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    1d3077a View commit details
    Browse the repository at this point in the history

  2. update integ test to use two different testConfigFiles 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9d61abd View commit details
    Browse the repository at this point in the history

  3. update integ snapshots 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    ffff9c3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @sumupitchayan
    sumupitchayan authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    530b23a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @sumupitchayan
    sumupitchayan authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8f55c58 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. add comment explaining why the children hash is used 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a0a2c0a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @sumupitchayan
    sumupitchayan authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    956cc54 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @sumupitchayan
    sumupitchayan authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    15276b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @sumupitchayan
    sumupitchayan authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    ae90224 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @sumupitchayan
    sumupitchayan authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    f7e98af View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @sumupitchayan
    sumupitchayan authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ed7e007 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

    @mikewrighton
    mikewrighton authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    bc6d73c View commit details
    Browse the repository at this point in the history