Skip to content

Navigation Menu

Explore
By size
By industry
By use case
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

aws / aws-cdk Public

Notifications You must be signed in to change notification settings
Fork 3.9k
Star 11.5k

Code
Issues 2.2k
Pull requests 137
Discussions
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): naming collisions when using `ec2.InitFile.fromAsset()` on multiple instances in the same stack #27468

Merged

mergify merged 17 commits into main from sumughan/fix-initfiles-with-same-filename

Oct 23, 2023

Conversation 5 Commits 17 Checks 12 Files changed

Merged

fix(ec2): naming collisions when using `ec2.InitFile.fromAsset()` on multiple instances in the same stack #27468

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

Select commit Hold shift + click to select a range

add first test case from issue repro code

sumupitchayan Oct 6, 2023

add md5hash(bindOptions.scope.node.id) to s3 asset name, but test is …

sumupitchayan Oct 9, 2023

change bind id hash to hash of md5hash(bindOptions.scope.node.childre…

sumupitchayan Oct 9, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

sumupitchayan Oct 9, 2023

write initial integ test and create snapshots

sumupitchayan Oct 9, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

sumupitchayan Oct 10, 2023

update integ test to use two different testConfigFiles

sumupitchayan Oct 10, 2023

update integ snapshots

sumupitchayan Oct 10, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

sumupitchayan Oct 10, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

sumupitchayan Oct 10, 2023

add comment explaining why the children hash is used

sumupitchayan Oct 11, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

sumupitchayan Oct 11, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

sumupitchayan Oct 11, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

sumupitchayan Oct 12, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

sumupitchayan Oct 16, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

sumupitchayan Oct 16, 2023

Merge branch 'main' into sumughan/fix-initfiles-with-same-filename

mikewrighton Oct 23, 2023

File filter

Filter by extension

Filter by extension .04c44be8722f4360fe0830af22298ad0870480310d7bd6eedbbd2391aecf59a8 (1) .b9ca21e9930115b91ab7e6877bec3bc97b410a6d41fd58816b56aba6db2643bd (1) .js (2) .json (9) .out (1) .ts (3) All 6 file types selected

Viewed files

Conversations

Failed to load comments.

Loading

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

- - integ.instance-init-multiple.ts
- - - cfn-init-elements.ts
  - - cfn-init-element.test.ts
    - - configFileForFirstInstance.json
      - configFileForSecondInstance.json

There are no files selected for viewing

1 change: 1 addition & 0 deletions 1 ...ltiple.js.snapshot/asset.04c44be8722f4360fe0830af22298ad0870480310d7bd6eedbbd2391aecf59a8

Show comments

Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

147 changes: 147 additions & 0 deletions 147 .../asset.1be0bac6581864b510bdbf0a114f1d3429244758da7657cc365f73d371fe70ed/__entrypoint__.js

Show comments

Open in desktop

Large diffs are not rendered by default.

Oops, something went wrong.

95 changes: 95 additions & 0 deletions 95 ....snapshot/asset.1be0bac6581864b510bdbf0a114f1d3429244758da7657cc365f73d371fe70ed/index.js

Show comments

Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

1 change: 1 addition & 0 deletions 1 ...ltiple.js.snapshot/asset.b9ca21e9930115b91ab7e6877bec3bc97b410a6d41fd58816b56aba6db2643bd

Show comments

Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

1 change: 1 addition & 0 deletions 1 ...esting/framework-integ/test/aws-ec2/test/integ.instance-init-multiple.js.snapshot/cdk.out

Show comments

Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

19 changes: 19 additions & 0 deletions 19 ...nstance-init-multiple.js.snapshot/instancetestDefaultTestDeployAssert5516EAF1.assets.json

Show comments

Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

36 changes: 36 additions & 0 deletions 36 ...tance-init-multiple.js.snapshot/instancetestDefaultTestDeployAssert5516EAF1.template.json

Show comments

Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

58 changes: 58 additions & 0 deletions 58 ...nteg.instance-init-multiple.js.snapshot/integ-ec2-multiple-instances-in-stack.assets.json

Show comments

Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

Loading

Oops, something went wrong.

Loading

Oops, something went wrong.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.