Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): skipping old cli integ test cdk diff changes in change set for new changes #30245

Merged
merged 2 commits into from
May 17, 2024
Merged

chore(cli): skipping old cli integ test cdk diff changes in change set for new changes #30245

merged 2 commits into from
May 17, 2024

Conversation

SankyRed
Copy link
Contributor

Fixes: 30093

@aws-cdk-automation aws-cdk-automation requested a review from a team May 16, 2024 22:57
@github-actions github-actions bot added the p2 label May 16, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 16, 2024
@SankyRed SankyRed changed the title fix(cli): skipping cli integ tests for old tests with new changes fix(integ): skipping cli integ tests for old tests with new changes May 16, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@SankyRed SankyRed temporarily deployed to test-pipeline May 16, 2024 23:05 — with GitHub Actions Inactive
@SankyRed
Copy link
Contributor Author

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

The fix is to skip old tests being tested against the new cli changes for diff stacks and fix the issue over the pipeline.

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6297fa1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@colifran colifran changed the title fix(integ): skipping cli integ tests for old tests with new changes chore(cli): skipping cli integ tests for old tests with new changes May 16, 2024
@colifran colifran added the pr/do-not-merge This PR should not be merged at this time. label May 16, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 16, 2024 23:34

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@colifran
Copy link
Contributor

Can you improve the title so we know what cli-integ test is being added? That way if we search our commits we will be able to easily identify which PR added the integ test to the regression suite.

@SankyRed SankyRed changed the title chore(cli): skipping cli integ tests for old tests with new changes chore(cli): skipping old cli integ test cdk diff changes in change set for new changes May 17, 2024
@SankyRed
Copy link
Contributor Author

Can you improve the title so we know what cli-integ test is being added? That way if we search our commits we will be able to easily identify which PR added the integ test to the regression suite.

This change is related skipping the old integ test but, updated the title with the test.

@SankyRed SankyRed added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/do-not-merge This PR should not be merged at this time. labels May 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1ba6e87 into main May 17, 2024
31 of 32 checks passed
@mergify mergify bot deleted the fix-30241-cli-integ branch May 17, 2024 01:16
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this pull request May 17, 2024
@SankyRed @mazyu36
chore(cli): skipping old cli integ test `cdk diff changes in change s…
8c0bbcb 
…et` for new changes (aws#30245)

Fixes: [30093](aws#30093)
@github-actions github-actions bot mentioned this pull request May 20, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bergjaak bergjaak bergjaak approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SankyRed @aws-cdk-automation @colifran @bergjaak