Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): skipping old cli integ test cdk diff changes in change set for new changes #30245

Merged
merged 2 commits into from
May 17, 2024
Merged

chore(cli): skipping old cli integ test cdk diff changes in change set for new changes #30245

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
924d52f
fix integ tests for old tests with new changes
SankyRed May 16, 2024
6297fa1
clean up
SankyRed May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...s/@aws-cdk-testing/cli-integ/resources/cli-regression-patches/v2.142.0/NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This patch brings the [fix](https://github.com/aws/aws-cdk/issues/30241) into the regression suite.
4 changes: 4 additions & 0 deletions packages/@aws-cdk-testing/cli-integ/resources/cli-regression-patches/v2.142.0/skip-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Skipping the test to fix issue https://github.com/aws/aws-cdk/issues/30241.
# cli-integ tests failing for the old tests with the new cli changes for list stacks.
SankyRed marked this conversation as resolved.
Show resolved Hide resolved

cdk diff picks up changes that are only present in changeset
Loading