Skip to content

Conversation

@msessa
Copy link
Contributor

@msessa msessa commented Jul 2, 2025

Issue # (if applicable)

Closes #34877

Reason for this change

The kubectl Provider function VpcConfig should match the Handler function.

Description of changes

  • Ensured the same vpc construct is passed to both Handler and Provider

Description of how you validated changes

  • Fixed the tests which were hiding the problem

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 2, 2025 06:18
@github-actions github-actions bot added bug This issue is a bug. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 2, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@msessa msessa changed the title fix(aws-eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration Jul 2, 2025
@msessa
Copy link
Contributor Author

msessa commented Jul 2, 2025

Exemption Request: No functional change to express in an integration test

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 2, 2025
@msessa msessa force-pushed the fix/eks-alpha-kubectl-vpc branch from ebfe321 to 6edc85b Compare July 2, 2025 07:02
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 2, 2025
@msessa msessa requested a review from aws-cdk-automation July 3, 2025 00:18
@vishaalmehrishi vishaalmehrishi self-assigned this Jul 7, 2025
Copy link
Contributor

@vishaalmehrishi vishaalmehrishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you for the fix!

@vishaalmehrishi
Copy link
Contributor

Re integration tests: I think it would be good to update existing tests/add new tests which verify that the provider and handler lambdas are set up using the same VPC configuration.

@msessa msessa force-pushed the fix/eks-alpha-kubectl-vpc branch from db0b136 to 6b84e80 Compare July 16, 2025 12:51
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 16, 2025
@msessa msessa force-pushed the fix/eks-alpha-kubectl-vpc branch from 6b84e80 to 65ea7d8 Compare July 17, 2025 04:07
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 65ea7d8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-eks-v2-alpha): kubectl provider function cannot be placed outside of VPC

3 participants