-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration #34878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Exemption Request: No functional change to express in an integration test |
ebfe321 to
6edc85b
Compare
vishaalmehrishi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thank you for the fix!
|
Re integration tests: I think it would be good to update existing tests/add new tests which verify that the provider and handler lambdas are set up using the same VPC configuration. |
db0b136 to
6b84e80
Compare
6b84e80 to
65ea7d8
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #34877
Reason for this change
The kubectl
ProviderfunctionVpcConfigshould match theHandlerfunction.Description of changes
vpcconstruct is passed to bothHandlerandProviderDescription of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license