Skip to content

fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration #34878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration #34878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be03815
fix(aws-eks-v2-alpha): ensure kubectl provider and handler functions …
msessa Jul 2, 2025
bab8f2c
chore: update integration test snapshots
msessa Jul 2, 2025
65ea7d8
chore: update snapshots
msessa Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-eks-v2-alpha/lib/kubectl-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ export class KubectlProvider extends Construct implements IKubectlProvider {

const provider = new cr.Provider(this, 'Provider', {
onEventHandler: handler,
vpc: props.cluster.vpc,
vpc: vpc,
vpcSubnets: privateSubnets,
securityGroups,
});
Expand Down
6 changes: 3 additions & 3 deletions packages/@aws-cdk/aws-eks-v2-alpha/test/cluster.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,7 +1816,7 @@ describe('cluster', () => {

// we don't attach vpc config in case endpoint is public only, regardless of whether
// the vpc has private subnets or not.
Template.fromStack(stack).hasResourceProperties('AWS::Lambda::Function', {
Template.fromStack(stack).allResourcesProperties('AWS::Lambda::Function', {
VpcConfig: Match.absent(),
});
});
Expand All @@ -1834,7 +1834,7 @@ describe('cluster', () => {

// we don't attach vpc config in case endpoint is public only, regardless of whether
// the vpc has private subnets or not.
Template.fromStack(stack).hasResourceProperties('AWS::Lambda::Function', {
Template.fromStack(stack).allResourcesProperties('AWS::Lambda::Function', {
VpcConfig: Match.absent(),
});
});
Expand Down Expand Up @@ -1884,7 +1884,7 @@ describe('cluster', () => {

// we don't have private subnets, but we don't need them since public access
// is not restricted.
Template.fromStack(stack).hasResourceProperties('AWS::Lambda::Function', {
Template.fromStack(stack).allResourcesProperties('AWS::Lambda::Function', {
VpcConfig: Match.absent(),
});
});
Expand Down
20 changes: 10 additions & 10 deletions ...lpha/test/integ.alb-controller.js.snapshot/aws-cdk-eks-cluster-alb-controller.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions ...ha/test/integ.alb-controller.js.snapshot/aws-cdk-eks-cluster-alb-controller.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,10 +951,6 @@
}
},
"Handler": "framework.onEvent",
"LoggingConfig": {
"ApplicationLogLevel": "FATAL",
"LogFormat": "JSON"
},
"Role": {
"Fn::GetAtt": [
"ClusterKubectlProviderframeworkonEventServiceRoleFD0BA8C5",
Expand Down Expand Up @@ -2012,10 +2008,6 @@
}
},
"Handler": "framework.onEvent",
"LoggingConfig": {
"ApplicationLogLevel": "FATAL",
"LogFormat": "JSON"
},
"Role": {
"Fn::GetAtt": [
"IngressPingerProviderframeworkonEventServiceRole89300FAD",
Expand Down
2 changes: 1 addition & 1 deletion ...er.js.snapshot/awscdkclusteralbcontrollerintegDefaultTestDeployAssert5A4A7C6A.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions packages/@aws-cdk/aws-eks-v2-alpha/test/integ.alb-controller.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-eks-v2-alpha/test/integ.alb-controller.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions ...dk/aws-eks-v2-alpha/test/integ.eks-addon.js.snapshot/EksClusterWithAddonStack.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions .../aws-eks-v2-alpha/test/integ.eks-addon.js.snapshot/EksClusterWithAddonStack.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,10 +1076,6 @@
}
},
"Handler": "framework.onEvent",
"LoggingConfig": {
"ApplicationLogLevel": "FATAL",
"LogFormat": "JSON"
},
"Role": {
"Fn::GetAtt": [
"ClusterKubectlProviderframeworkonEventServiceRoleFD0BA8C5",
Expand Down
2 changes: 1 addition & 1 deletion ...nteg.eks-addon.js.snapshot/EksClusterwithAddonDefaultTestDeployAssert82CE7357.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions packages/@aws-cdk/aws-eks-v2-alpha/test/integ.eks-addon.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-eks-v2-alpha/test/integ.eks-addon.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions ...eg.eks-al2023-nodegroup.js.snapshot/aws-cdk-eks-cluster-al2023-nodegroup-test.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions ....eks-al2023-nodegroup.js.snapshot/aws-cdk-eks-cluster-al2023-nodegroup-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,10 +879,6 @@
}
},
"Handler": "framework.onEvent",
"LoggingConfig": {
"ApplicationLogLevel": "FATAL",
"LogFormat": "JSON"
},
"Role": {
"Fn::GetAtt": [
"ClusterKubectlProviderframeworkonEventServiceRoleFD0BA8C5",
Expand Down
2 changes: 1 addition & 1 deletion ...up.js.snapshot/awscdkeksclusteral2023nodegroupDefaultTestDeployAssert96F213C8.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading