Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init-templates): remove dependency on @types/node #3840

Merged
merged 2 commits into from
Aug 28, 2019
Merged

fix(init-templates): remove dependency on @types/node #3840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66b0647
fix(init-templates): remove dependency on @types/node
RomainMuller Aug 28, 2019
03eb26a
also pin typescript compiler version to current minor
RomainMuller Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"nyc": "^14.1.1",
"ts-jest": "^24.0.2",
"tslint": "^5.19.0",
"typescript": "^3.5.3"
"typescript": "~3.5.3"
},
"repository": {
"type": "git",
Expand Down
2 changes: 0 additions & 2 deletions packages/aws-cdk/lib/init-templates/app/javascript/bin/%name%.template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#!/usr/bin/env node

// @ts-ignore: Cannot find declaration file
require('source-map-support/register');
const cdk = require('@aws-cdk/core');
const { %name.PascalCased%Stack } = require('../lib/%name%-stack');

Expand Down
7 changes: 1 addition & 6 deletions packages/aws-cdk/lib/init-templates/app/javascript/package.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,12 @@
"%name%": "bin/%name%.js"
},
"scripts": {
"test": "tsc",
"test:watch": "tsc -w",
"cdk": "cdk"
},
"devDependencies": {
"@types/node": "8.10.45",
"typescript": "^3.3.3333",
"aws-cdk": "^%cdk-version%"
},
"dependencies": {
"@aws-cdk/core": "^%cdk-version%",
"source-map-support": "^0.5.9"
"@aws-cdk/core": "^%cdk-version%"
}
}
28 changes: 0 additions & 28 deletions packages/aws-cdk/lib/init-templates/app/javascript/tsconfig.json
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions packages/aws-cdk/lib/init-templates/app/typescript/package.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
"cdk": "cdk"
},
"devDependencies": {
"@types/node": "8.10.45",
"typescript": "^3.3.3333",
"aws-cdk": "^%cdk-version%",
"ts-node": "^8.1.0",
"aws-cdk": "^%cdk-version%"
"typescript": "~3.5.3"
},
"dependencies": {
"@aws-cdk/core": "^%cdk-version%",
Expand Down
7 changes: 2 additions & 5 deletions packages/aws-cdk/lib/init-templates/lib/typescript/package.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,10 @@
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"watch": "tsc -w",
"test": "nodeunit test/test.*.js"
"watch": "tsc -w"
},
"devDependencies": {
"@types/nodeunit": "^0.0.30",
"nodeunit": "^0.11.2",
"typescript": "^3.3.3333"
"typescript": "~3.5.3"
},
"peerDependencies": {
"@aws-cdk/core": "^%cdk-version%"
Expand Down
5 changes: 2 additions & 3 deletions packages/aws-cdk/lib/init-templates/sample-app/typescript/package.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
"cdk": "cdk"
},
"devDependencies": {
"@types/node": "8.10.45",
"typescript": "^3.3.3333",
"aws-cdk": "^%cdk-version%",
"ts-node": "^8.1.0",
"aws-cdk": "^%cdk-version%"
"typescript": "~3.5.3"
},
"dependencies": {
"@aws-cdk/aws-sns": "^%cdk-version%",
Expand Down
2 changes: 1 addition & 1 deletion packages/decdk/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/awslint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@types/fs-extra": "^8.0.0",
"@types/yargs": "^13.0.2",
"tslint": "^5.18.0",
"typescript": "^3.5.3"
"typescript": "~3.5.3"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion tools/cdk-build-tools/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/cdk-build-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"nyc": "^14.1.1",
"ts-jest": "^24.0.2",
"tslint": "^5.18.0",
"typescript": "^3.5.3",
"typescript": "~3.5.3",
"yargs": "^13.3.0"
},
"keywords": [
Expand Down