Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init-templates): remove dependency on @types/node #3840

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

RomainMuller
Copy link
Contributor

That was not required anymore since we no longer require passing the
command line arguments to the app.run() call. This dependency has the
potential of causing collisions with the ES libraries included by the
TypeScript compiler, and specifying a correct version can be a delicate
exercise, especially as those templates have to keep working in the
future.

Additionally, pinned the TypeScript compiler version to the current
minor, as recommended by the TypeScript maintainers (TypeScript does not
honor SemVer, but guarantees no breaking change between stable releases,
which they indicate by issuing a new major version).

Fixes #3839


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

That was not required anymore since we no longer require passing the
command line arguments to the `app.run()` call. This dependency has the
potential of causing collisions with the ES libraries included by the
TypeScript compiler, and specifying a correct version can be a delicate
exercise, especially as those templates have to keep working in the
future.

Additionally, pinned the TypeScript compiler version to the current
minor, as recommended by the TypeScript maintainers (TypeScript does not
honor SemVer, but guarantees no breaking change between stable releases,
which they indicate by issuing a new major version).

Fixes #3839
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit f46ce18 into master Aug 28, 2019
@mergify mergify bot deleted the rmuller/fix-init-template branch August 28, 2019 21:17
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
eladb pushed a commit that referenced this pull request Nov 11, 2019
Since it is very common for users to need to reference local files using `path.join` and `__dirname`, it is only pragmatic that we will include @types/node in the init template.

We use a pinned version since experience shows that these types can get a bit messed up (see #3839)

Supersedes #4462
Reverts #3840
mergify bot pushed a commit that referenced this pull request Nov 11, 2019
Since it is very common for users to need to reference local files using `path.join` and `__dirname`, it is only pragmatic that we will include @types/node in the init template.

We use a pinned version since experience shows that these types can get a bit messed up (see #3839)

Supersedes #4462
Reverts #3840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues compiling CDK projects ("TS2300: Duplicate identifier 'IteratorResult'")
3 participants