-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues compiling CDK projects ("TS2300: Duplicate identifier 'IteratorResult'") #3839
Labels
Comments
RomainMuller
added
bug
This issue is a bug.
package/tools
Related to AWS CDK Tools or CLI
labels
Aug 28, 2019
RomainMuller
added a commit
that referenced
this issue
Aug 28, 2019
That was not required anymore since we no longer require passing the command line arguments to the `app.run()` call. This dependency has the potential of causing collisions with the ES libraries included by the TypeScript compiler, and specifying a correct version can be a delicate exercise, especially as those templates have to keep working in the future. Additionally, pinned the TypeScript compiler version to the current minor, as recommended by the TypeScript maintainers (TypeScript does not honor SemVer, but guarantees no breaking change between stable releases, which they indicate by issuing a new major version). Fixes #3839
mergify bot
pushed a commit
that referenced
this issue
Aug 28, 2019
* fix(init-templates): remove dependency on @types/node That was not required anymore since we no longer require passing the command line arguments to the `app.run()` call. This dependency has the potential of causing collisions with the ES libraries included by the TypeScript compiler, and specifying a correct version can be a delicate exercise, especially as those templates have to keep working in the future. Additionally, pinned the TypeScript compiler version to the current minor, as recommended by the TypeScript maintainers (TypeScript does not honor SemVer, but guarantees no breaking change between stable releases, which they indicate by issuing a new major version). Fixes #3839 * also pin typescript compiler version to current minor
Doesn't work for me, it still throws the same error as before.
|
eladb
pushed a commit
that referenced
this issue
Nov 11, 2019
Since it is very common for users to need to reference local files using `path.join` and `__dirname`, it is only pragmatic that we will include @types/node in the init template. We use a pinned version since experience shows that these types can get a bit messed up (see #3839) Supersedes #4462 Reverts #3840
mergify bot
pushed a commit
that referenced
this issue
Nov 11, 2019
Since it is very common for users to need to reference local files using `path.join` and `__dirname`, it is only pragmatic that we will include @types/node in the init template. We use a pinned version since experience shows that these types can get a bit messed up (see #3839) Supersedes #4462 Reverts #3840
jimrandomh
added a commit
to ForumMagnum/ForumMagnum
that referenced
this issue
Dec 6, 2019
Issue and fix described in aws/aws-cdk#3839
kgregory-chariot
added a commit
to chariotsolutions/aws-examples
that referenced
this issue
Dec 27, 2019
kgregory-chariot
added a commit
to chariotsolutions/aws-examples
that referenced
this issue
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Applications created using the current "init templates" for TypeScript may fail building with the following error message:
This can be fixed by removing the
@types/node
dependency declared inpackage.json
, or upgrading it from8.10.45
to8.10.52
, by running the following command:The text was updated successfully, but these errors were encountered: