Skip to content

Commit

Permalink
feat(cli): add @types/node to typescript init templates (#4947)
Browse files Browse the repository at this point in the history
Since it is very common for users to need to reference local files using `path.join` and `__dirname`, it is only pragmatic that we will include @types/node in the init template.

We use a pinned version since experience shows that these types can get a bit messed up (see #3839)

Supersedes #4462
Reverts #3840
  • Loading branch information
Elad Ben-Israel authored and mergify[bot] committed Nov 11, 2019
1 parent db50ab0 commit efde8e9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"devDependencies": {
"@aws-cdk/assert": "^%cdk-version%",
"@types/jest": "^24.0.18",
"@types/node": "10.3.0",
"jest": "^24.9.0",
"ts-jest": "^24.0.2",
"aws-cdk": "^%cdk-version%",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"devDependencies": {
"@aws-cdk/assert": "^%cdk-version%",
"@types/jest": "^24.0.18",
"@types/node": "10.3.0",
"jest": "^24.9.0",
"ts-jest": "^24.0.2",
"typescript": "~3.6.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"aws-cdk": "^%cdk-version%",
"@aws-cdk/assert": "^1.6.1",
"@types/jest": "^24.0.18",
"@types/node": "10.3.0",
"jest": "^24.9.0",
"ts-jest": "^24.0.2",
"ts-node": "^8.1.0",
Expand Down

0 comments on commit efde8e9

Please sign in to comment.