Add `cdk init` template for .NET, and re-enable .NET targets #617

mpiroc · 2018-08-22T22:28:26Z

This change builds upon @RomainMuller's pull request #524.

Build the CDK for .NET by adding .NET target information to each @aws-cdk package.
Add mechanism for cdk init template authors to execute arbitrary (javascript) code during initialization.
Add a cdk-init template for .NET.

This change depends on the latest version of jsii, and should not be merged until that version is published to npmjs.com.

It also depends on the .NET JSII NuGet packages being published to NuGet.org. If you want to try out this changeset before they are published, add a file NuGet.config to your project's root directory after running cdk init, with these contents (you will need to update the paths for your machine):

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
    <add key="jsii-dotnet-jsonmodel" value="C:\repos\jsii\packages\jsii-dotnet-jsonmodel\bin\Release\NuGet" />
    <add key="jsii-dotnet-generator" value="C:\repos\jsii\packages\jsii-dotnet-generator\bin\Release\NuGet" />
    <add key="jsii-dotnet-runtime" value="C:\repos\jsii\packages\jsii-dotnet-runtime\bin\Release\NuGet" />
    <add key="cdk-dotnet" value="C:\repos\aws-cdk\pack\dotnet" />
  </packageSources>
</configuration>

…o Nuget)" This reverts commit 5d116e3.

…uest.

rix0rrr · 2018-08-23T06:57:27Z

Why don't we default packageId from namespace?

rix0rrr · 2018-08-23T08:34:31Z

packages/aws-cdk/lib/init-templates/app/dotnet/README.md

+You should explore the contents of this template. It demonstrates a CDK app with two instances of
+a stack (`HelloStack`) which also uses a user-defined construct (`HelloConstruct`).
+
+The `cdk.json` file tells the CDK Toolkit how to execute your app. It uses a script called `app.sh`


app.sh on Windows?

For now I'm following the pattern from the Java init template. Other languages vs .NET is orthogonal to OS--we should provide cross-platform scripts in every template.

Changed to invoke the dotnet CLI directly, rather than through a script.
✔️

rix0rrr · 2018-08-23T08:35:04Z

packages/aws-cdk/lib/init-templates/app/dotnet/cdk.json

+{
+  "app": "/bin/bash ./app.sh"
+}
+


Trailing whitespace here

rix0rrr · 2018-08-23T08:35:53Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloConstruct.cs

+            }
+        }
+
+        public void GrantRead(IIIdentityResource principal)


IIIdentityResource?

Did we still not make a decision on this?

It was punted to a future release--there are several edge cases to consider (what if IdentityResource and IIdentityResource are both interfaces? What if an interface has a name like IAMMyInterface?). See aws/jsii#109.

tools/pkglint/lib/rules.ts

rix0rrr · 2018-08-23T11:25:40Z

This change depends on the latest version of jsii, and should not be merged until that version is published to npmjs.com.

I just published 0.7.0, but you submitted two more changes just after we locked in 0.7.0. Are those final two commits required?

It also depends on the .NET JSII NuGet packages being published to NuGet.org.

Who is working on that? There is a "PublishJSIIToNuGet" job, but I'm expecting it to not do anything if I were to run that right now, correct?

mpiroc · 2018-08-23T19:15:42Z

Why don't we default packageId from namespace?

We could--I required both so that it's clear how each value is used. If we only require one, I'd suggest making packageId required and default namespace to packageId.

I just published 0.7.0, but you submitted two more changes just after we locked in 0.7.0. Are those final two commits required?

Yes, they are required.

Who is working on that? There is a "PublishJSIIToNuGet" job, but I'm expecting it to not do anything if I were to run that right now, correct?

@costleya completed the MCM yesterday (can now assume a role to get the necessary secrets). My next task after this init template is to implement the job.

costleya · 2018-08-23T21:19:30Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloConstruct.cs

+{
+    public class HelloConstruct : Construct
+    {
+        readonly IList<Bucket> _buckets = new List<Bucket>();


private readonly IEnumerable buckets;

costleya · 2018-08-23T21:25:29Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloConstruct.cs

+
+        public HelloConstruct(Construct parent, string id, HelloConstructProps props) : base(parent, id)
+        {
+            foreach (int i in Enumerable.Range(0, props.BucketCount))


move to GenerateBuckets method that returns an IEnumerable. Chnage line to _buckets = GenerateBuckets(props.BucketCount);

private IEnumerable GenerateBuckets() => Enumerable.Range(0, number).Select(number => new Bucket(this, $"Bucket{i}", new BucketProps())));

✔️ (simplified in a slightly different way)

costleya · 2018-08-23T21:26:10Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloConstruct.cs

+
+        public void GrantRead(IIIdentityResource principal)
+        {
+            foreach (Bucket bucket in _buckets)


I'm keeping Bucket in this instance, as the type of _buckets appears elsewhere in the file. See CoreFX Coding Style:

We only use var when it's obvious what the variable type is (e.g. var stream = new FileStream(...) not var stream = OpenStandardInput()).

Still disagree, but I'll let it pass.

costleya · 2018-08-23T21:26:43Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloStack.cs

+    {
+        public HelloStack(App parent, string name, IStackProps props) : base(parent, name, props)
+        {
+            Queue queue = new Queue(this, "MyFirstQueue", new QueueProps


costleya · 2018-08-23T21:26:56Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloStack.cs

+                VisibilityTimeoutSec = 300
+            });
+
+            Topic topic = new Topic(this, "MyFirstTopic", new TopicProps


costleya · 2018-08-23T21:27:22Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/Program.cs

+    {
+        static void Main(string[] args)
+        {
+            App app = new App(args);


costleya · 2018-08-23T21:28:15Z

packages/aws-cdk/lib/init.ts

+        files.sort(); // Sorting allows template authors to control the order in which hooks are invoked.
+
+        for (const file of files) {
+            if ((file.match(/^.*\.hook\.js$/))) {


extraneous parenth

costleya · 2018-08-23T21:29:18Z

tools/pkglint/lib/rules.ts

@@ -218,14 +219,41 @@ function cdkModuleName(name: string) {
    name = name.replace(/^aws-cdk-/, '');
    name = name.replace(/^@aws-cdk\//, '');

+    const dotnetSuffix = name.split('-').map(s => s === 'aws' ? 'AWS' : caseUtils.pascal(s)).join('.');


use some new lines to make this easier to follow

rix0rrr · 2018-08-24T08:21:09Z

If we only require one, I'd suggest making packageId required and default namespace to packageId.

That is I believe the straight opposite of what we do for Java packages. I'd rather keep it the same.

Also jsii users that never publish to NuGet maybe don't care about a packageId, but they WILL care about the namespace.

mpiroc · 2018-08-24T23:21:46Z

@rix0rrr Makes sense. This is a separate change, so I created aws/jsii#198 to track it.

eladb · 2018-08-28T08:59:31Z

packages/@aws-cdk/aws-sqs/lib/queue.ts


    protected readonly autoCreatePolicy = true;

+    private _encryptionMasterKey?: kms.EncryptionKeyRef;


What's the rational for this change? Is this in order to turn it into readonly? I would just add readonly and return a value from determineEncryptionProps so it can be set in the ctor

eladb · 2018-08-28T09:02:51Z

packages/aws-cdk/lib/init-templates/app/dotnet/app.sh

+# This script is configured in cdk.json to be used to
+# execute the CDK .NET app by the command-line toolkit.
+# The first argument will be used as argv[0]
+exec dotnet run src/HelloCdk/bin/Release/HelloCdk $@


I don't think you need this script, I think you can just put dotnet run src/HelloCdk/bin/Release/HelloCdk in the cdk.json file

eladb · 2018-08-28T09:03:05Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloCdk.csproj

+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Amazon.CDK" Version="0.8.2" />


The version should not be hard-coded!

eladb · 2018-08-28T09:03:31Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloConstruct.cs

+
+namespace HelloCdk
+{
+    public class HelloConstruct : Construct


Add some documentation across the board to explain what you are doing

✔️
FYI, the Java template has no documentation either. Once this PR is finished, I'll create another for (near-identical) Java comments.

eladb · 2018-08-28T09:03:51Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloConstruct.cs

+        public HelloConstruct(Construct parent, string id, HelloConstructProps props) : base(parent, id)
+        {
+            _buckets = Enumerable.Range(0, props.BucketCount)
+                .Select(i => new Bucket(this, $"Bucket{i}", new BucketProps()))


Any reason you need to initialize an empty BucketProps? It should be optional I believe

It's marked as optional, but there's a bug in bucket.ts:

const encryptionType = props.encryption || BucketEncryption.Unencrypted;

This fails is props is null. This is easy to fix:

const encryptionType = (props && props.encryption) ? props.encryption : BucketEncryption.Unencrypted

I'll submit a separate PR with the fix.

eladb · 2018-08-28T09:04:23Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloConstructProps.cs

+
+namespace HelloCdk
+{
+    public class HelloConstructProps


I would recommend placing this class alongside HelloConstruct. As far as I know .NET doesn't require a class-per-file and moreover, encourages co-locating related classes, especially like this one.

It doesn't require class per file. However, co-location is a judgement call. In this case, I can agree that your suggestion makes sense. In practice, I usually do one class per file anyway.

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/HelloStack.cs

eladb · 2018-08-28T09:05:57Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/Program.cs

+        {
+            var app = new App(args);
+
+            new HelloStack(app, "hello-cdk-1", new StackProps());


Why do you need to specify StackProps if it's empty?

Maybe the generated code doesn't allow default parameters?

This is due to my oversight in the generator--it doesn't generate default values for arguments with optional types. I thought there was an issue for this, but I don't see one. New issue is here: aws/jsii#210.

In the meantime, we can pass null rather than new StackProps().

eladb · 2018-08-28T09:06:46Z

packages/aws-cdk/lib/init.ts

            } else {
                await fs.copy(fromFile, toFile);
            }
        }
    }

+    private async invokeHooks(sourceDirectory: string, targetDirectory: string) {


Add a comment explaining what this is doing

…ode review.

leepa · 2018-09-05T07:01:54Z

install.sh

@@ -5,9 +5,9 @@ echo "==========================================================================
 echo "installing repo-global dependencies..."
 npm i --no-package-lock --global-style

-# Now that we have lerna available...
+# Now that we have lerna --concurrency 1 available...


Seems like a find and replace but the comment here shouldn't of changed.

leepa · 2018-09-05T07:02:34Z

packages/@aws-cdk/assets/package.json

@@ -56,4 +60,4 @@
    "@aws-cdk/cx-api": "^0.8.2"
  },
  "homepage": "https://github.com/awslabs/aws-cdk"
-}
+}


Your editor has stripped new line at end of file on a few files making the diff larger than needed.

mpiroc · 2018-09-05T18:10:02Z

Note: This change depends on jsii-pacmak >=0.7.1, which is why the CI build is failing.

eladb

Minor comments

eladb · 2018-09-06T17:09:31Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/Program.cs

+            new HelloStack(app, "hello-cdk-1", new StackProps());
+            new HelloStack(app, "hello-cdk-2", new StackProps());
+
+            // Your app must write the return value of app.Run() to standard output. The `cdk init`


It's only needed by cdk synth

eladb · 2018-09-06T17:10:13Z

packages/aws-cdk/lib/init-templates/app/dotnet/src/HelloCdk/Program.cs

+            string[] appArgs = new [] { $"dotnet ${nameof(HelloCdk)}" }
+                .Concat(args)
+                .ToArray();
+            var app = new App(appArgs);


Any way we can make this more concise? The usage message is not viewed by anyone, I would just write "app" as argv0

costleya · 2018-09-05T01:36:22Z

packages/aws-cdk/lib/init-templates/app/dotnet/cdk.json

@@ -1,3 +1,3 @@
 {
-  "app": "/bin/bash ./app.sh"
+  "app": "dotnet src/HelloCdk/bin/Debug/netcoreapp2.1/HelloCdk.dll"


Do we want to put the DLL in a less nested directory?

rix0rrr · 2018-09-10T18:52:14Z

Ah, building this fails because of

@aws-cdk/cx-api: /tmp/jsii-pacmak-codePbuUgz/Amazon.CDK.CXAPI/Amazon.CDK.CXAPI.csproj : error NU1101: Unable to find package Amazon.JSII.Runtime. No packages exist with this id in source(s): nuget.org\n    0 Warning(s)\n    1 Error(s)

I see.

@mpiroc

The headliners of this release are __.NET support__, and a wealth of commits by external contributors who are stepping up to fix the CDK for their use cases! Thanks all for the effort put into this release! * Add strongly-named .NET targets, and a `cdk init` template for C# projects ([@mpiroc] in [#617](#617), [#643](#643)). * __@aws-cdk/aws-autoscaling__: Allow attaching additional security groups to Launch Configuration ([@moofish32] in [#636](#636)). * __@aws-cdk/aws-autoscaling__: Support update and creation policies on AutoScalingGroups ([@rix0rrr] in [#595](#595)). * __@aws-cdk/aws-codebuild__: Add support for running script from an asset ([@rix0rrr] in [#677](#677)). * __@aws-cdk/aws-codebuild__: New method `addBuildToPipeline` on Project ([@skinny85] in [783dcb3](783dcb3)). * __@aws-cdk/aws-codecommit__: New method `addToPipeline` on Repository ([@skinny85] in [#616](#616)). * __@aws-cdk/aws-codedeploy__: Add initial support for CodeDeploy ([@skinny85] in [#593](#593), [#641](#641)). * __@aws-cdk/aws-dynamodb__: Add support for DynamoDB autoscaling ([@SeekerWing] in [#637](#637)). * __@aws-cdk/aws-dynamodb__: Add support for DynamoDB streams ([@rhboyd] in [#633](#633)). * __@aws-cdk/aws-dynamodb__: Add support for server-side encryption ([@jungseoklee] in [#684](#864)). * __@aws-cdk/aws-ec2__ (_**BREAKING**_): SecurityGroup can now be used as a Connectable [#582](#582)). * __@aws-cdk/aws-ec2__: Add VPC tagging ([@moofish] in [#538](#538)). * __@aws-cdk/aws-ec2__: Add support for `InstanceSize.Nano` ([@rix0rrr] in [#581](#581)) * __@aws-cdk/aws-lambda__: Add support for dead letter queues ([@SeekerWing] in [#663](#663)). * __@aws-cdk/aws-lambda__: Add support for placing a Lambda in a VPC ([@rix0rrr] in [#598](#598)). * __@aws-cdk/aws-logs__: Add `extractMetric()` helper function ([@rix0rrr] in [#676](#676)). * __@aws-cdk/aws-rds__: Add support for Aurora PostreSQL/MySQL engines ([@cookejames] in [#586](#586)) * __@aws-cdk/aws-s3__: Additional grant methods for Buckets ([@eladb] in [#591](#591)) * __@aws-cdk/aws-s3__: New method `addToPipeline` on Bucket ([@skinny85] in [c8b7a49](c8b7a49)). * __aws-cdk__: Add support for HTTP proxies ([@rix0rrr] in [#666](#666)). * __aws-cdk__: Toolkit now shows failure reason if stack update fails ([@rix0rrr] in [#609](#609)). * __cdk-build-tools__: Add support for running experiment JSII versions ([@RomainMuller] in [#649](#649)). * _**BREAKING**_: Generate classes and types for the CloudFormation resource `.ref` attributes ([@rix0rrr] in [#627](#627)). * _**BREAKING**_: Make types accepted in Policy-related classes narrower (from `any` to `Arn`, for example) to reduce typing mistakes ([@rix0rrr] in [#629](#629)). * __@aws-cdk/aws-codepipeline__ (_**BREAKING**_): Align the CodePipeline APIs ([@skinny85] in [#492](#492), [#568](#568)) * __@aws-cdk/aws-ec2__ (_**BREAKING**_): Move Fleet/AutoScalingGroup to its own package ([@rix0rrr] in [#608](#608)). * __aws-cdk__: Simplify plugin protocol ([@RomainMuller] in [#646](#646)). * __@aws-cdk/aws-cloudfront__: Fix CloudFront behavior for ViewerProtocolPolicy ([@mindstorms6] in [#615](#615)). * __@aws-cdk/aws-ec2__: VPC Placement now supports picking Isolated subnets ([@rix0rrr] in [#610](#610)). * __@aws-cdk/aws-logs__: Add `export()/import()` capabilities ([@rix0rrr] in [#630](#630)). * __@aws-cdk/aws-rds__: Fix a bug where a cluster with 1 instance could not be created ([@cookejames] in [#578](#578)) * __@aws-cdk/aws-s3__: Bucket notifications can now add dependencies, fixing creation order ([@eladb] in [#584](#584)). * __@aws-cdk/aws-s3__: Remove useless bucket name validation ([@rix0rrr] in [#628](#628)). * __@aws-cdk/aws-sqs__: Make `QueueRef.encryptionMasterKey` readonly ([@RomainMuller] in [#650](#650)). * __assets__: S3 read permissions are granted on a prefix to fix lost permissions during asset update ([@rix0rrr] in [#510](#510)). * __aws-cdk__: Remove bootstrapping error if multiple stacks are in the same environment ([@RomainMuller] in [#625](#625)). * __aws-cdk__: Report and continue if git throws errors during `cdk init` ([@rix0rrr] in [#587](#587)). * __@aws-cdk/cfnspec__: Updated [CloudFormation resource specification] to `v2.6.0` ([@RomainMuller] in [#594](#594)) + **New AWS Construct Library** - `@aws-cdk/aws-sagemaker` supports AWS::SageMaker resources + **New Resource Types** - AWS::AmazonMQ::Broker - AWS::AmazonMQ::Configuration - AWS::CodePipeline::Webhook - AWS::Config::AggregationAuthorization - AWS::Config::ConfigurationAggregator - AWS::EC2::VPCEndpointConnectionNotification - AWS::EC2::VPCEndpointServicePermissions - AWS::IAM::ServiceLinkedRole - AWS::SSM::ResourceDataSync - AWS::SageMaker::Endpoint - AWS::SageMaker::EndpointConfig - AWS::SageMaker::Model - AWS::SageMaker::NotebookInstance - AWS::SageMaker::NotebookInstanceLifecycleConfig + **Attribute Changes** - AWS::CodePipeline::Pipeline Version (__added__) + **Property Changes** - AWS::AppSync::DataSource HttpConfig (__added__) - AWS::DAX::Cluster SSESpecification (__added__) - AWS::DynamoDB::Table Stream (__added__) - AWS::DynamoDB::Table AutoScalingSupport (__added__) - AWS::EC2::VPCEndpoint IsPrivateDnsEnabled (__added__) - AWS::EC2::VPCEndpoint SecurityGroupIds (__added__) - AWS::EC2::VPCEndpoint SubnetIds (__added__) - AWS::EC2::VPCEndpoint VPCEndpointType (__added__) - AWS::EC2::VPCEndpoint RouteTableIds.DuplicatesAllowed (__deleted__) - AWS::EC2::VPCPeeringConnection PeerRegion (__added__) - AWS::EFS::FileSystem ProvisionedThroughputInMibps (__added__) - AWS::EFS::FileSystem ThroughputMode (__added__) - AWS::EMR::Cluster KerberosAttributes (__added__) - AWS::Glue::Classifier JsonClassifier (__added__) - AWS::Glue::Classifier XMLClassifier (__added__) - AWS::Glue::Crawler Configuration (__added__) - AWS::Lambda::Lambda DLQConfigurationSupport (__added__) - AWS::Neptune::DBInstance DBSubnetGroupName.UpdateType (__changed__) - Old: Mutable - New: Immutable - AWS::SNS::Subscription DeliveryPolicy (__added__) - AWS::SNS::Subscription FilterPolicy (__added__) - AWS::SNS::Subscription RawMessageDelivery (__added__) - AWS::SNS::Subscription Region (__added__) - AWS::SQS::Queue Tags (__added__) - AWS::ServiceDiscovery::Service HealthCheckCustomConfig (__added__) + **Property Type Changes** - AWS::AppSync::DataSource.HttpConfig (__added__) - AWS::DAX::Cluster.SSESpecification (__added__) - AWS::EMR::Cluster.KerberosAttributes (__added__) - AWS::Glue::Classifier.JsonClassifier (__added__) - AWS::Glue::Classifier.XMLClassifier (__added__) - AWS::ServiceDiscovery::Service.HealthCheckCustomConfig (__added__) - AWS::CloudFront::Distribution.CacheBehavior FieldLevelEncryptionId (__added__) - AWS::CloudFront::Distribution.DefaultCacheBehavior FieldLevelEncryptionId (__added__) - AWS::CodeBuild::Project.Artifacts EncryptionDisabled (__added__) - AWS::CodeBuild::Project.Artifacts OverrideArtifactName (__added__) - AWS::CodeBuild::Project.Environment Certificate (__added__) - AWS::CodeBuild::Project.Source ReportBuildStatus (__added__) - AWS::ServiceDiscovery::Service.DnsConfig RoutingPolicy (__added__) - AWS::WAF::WebACL.ActivatedRule Action.Required (__changed__) - Old: true - New: false * __@aws-cdk/cfnspec__: Updated Serverless Application Model (SAM) Resource Specification ([@RomainMuller] in [#594](#594)) + **Property Changes** - AWS::Serverless::Api MethodSettings (__added__) + **Property Type Changes** - AWS::Serverless::Function.SQSEvent (__added__) - AWS::Serverless::Function.EventSource Properties.Types (__changed__) - Added SQSEvent

@mpiroc

The headliners of this release are __.NET support__, and a wealth of commits by external contributors who are stepping up to fix the CDK for their use cases! Thanks all for the effort put into this release! * Add strongly-named .NET targets, and a `cdk init` template for C# projects ([@mpiroc] in [#617](#617), [#643](#643)). * __@aws-cdk/aws-autoscaling__: Allow attaching additional security groups to Launch Configuration ([@moofish32] in [#636](#636)). * __@aws-cdk/aws-autoscaling__: Support update and creation policies on AutoScalingGroups ([@rix0rrr] in [#595](#595)). * __@aws-cdk/aws-codebuild__: Add support for running script from an asset ([@rix0rrr] in [#677](#677)). * __@aws-cdk/aws-codebuild__: New method `addBuildToPipeline` on Project ([@skinny85] in [783dcb3](783dcb3)). * __@aws-cdk/aws-codecommit__: New method `addToPipeline` on Repository ([@skinny85] in [#616](#616)). * __@aws-cdk/aws-codedeploy__: Add initial support for CodeDeploy ([@skinny85] in [#593](#593), [#641](#641)). * __@aws-cdk/aws-dynamodb__: Add support for DynamoDB autoscaling ([@SeekerWing] in [#637](#637)). * __@aws-cdk/aws-dynamodb__: Add support for DynamoDB streams ([@rhboyd] in [#633](#633)). * __@aws-cdk/aws-dynamodb__: Add support for server-side encryption ([@jungseoklee] in [#684](#864)). * __@aws-cdk/aws-ec2__ (_**BREAKING**_): SecurityGroup can now be used as a Connectable [#582](#582)). * __@aws-cdk/aws-ec2__: Add VPC tagging ([@moofish] in [#538](#538)). * __@aws-cdk/aws-ec2__: Add support for `InstanceSize.Nano` ([@rix0rrr] in [#581](#581)) * __@aws-cdk/aws-lambda__: Add support for dead letter queues ([@SeekerWing] in [#663](#663)). * __@aws-cdk/aws-lambda__: Add support for placing a Lambda in a VPC ([@rix0rrr] in [#598](#598)). * __@aws-cdk/aws-logs__: Add `extractMetric()` helper function ([@rix0rrr] in [#676](#676)). * __@aws-cdk/aws-rds__: Add support for Aurora PostreSQL/MySQL engines ([@cookejames] in [#586](#586)) * __@aws-cdk/aws-s3__: Additional grant methods for Buckets ([@eladb] in [#591](#591)) * __@aws-cdk/aws-s3__: New method `addToPipeline` on Bucket ([@skinny85] in [c8b7a49](c8b7a49)). * __aws-cdk__: Add support for HTTP proxies ([@rix0rrr] in [#666](#666)). * __aws-cdk__: Toolkit now shows failure reason if stack update fails ([@rix0rrr] in [#609](#609)). * __cdk-build-tools__: Add support for running experiment JSII versions ([@RomainMuller] in [#649](#649)). * _**BREAKING**_: Generate classes and types for the CloudFormation resource `.ref` attributes ([@rix0rrr] in [#627](#627)). * _**BREAKING**_: Make types accepted in Policy-related classes narrower (from `any` to `Arn`, for example) to reduce typing mistakes ([@rix0rrr] in [#629](#629)). * __@aws-cdk/aws-codepipeline__ (_**BREAKING**_): Align the CodePipeline APIs ([@skinny85] in [#492](#492), [#568](#568)) * __@aws-cdk/aws-ec2__ (_**BREAKING**_): Move Fleet/AutoScalingGroup to its own package ([@rix0rrr] in [#608](#608)). * __aws-cdk__: Simplify plugin protocol ([@RomainMuller] in [#646](#646)). * __@aws-cdk/aws-cloudfront__: Fix CloudFront behavior for ViewerProtocolPolicy ([@mindstorms6] in [#615](#615)). * __@aws-cdk/aws-ec2__: VPC Placement now supports picking Isolated subnets ([@rix0rrr] in [#610](#610)). * __@aws-cdk/aws-logs__: Add `export()/import()` capabilities ([@rix0rrr] in [#630](#630)). * __@aws-cdk/aws-rds__: Fix a bug where a cluster with 1 instance could not be created ([@cookejames] in [#578](#578)) * __@aws-cdk/aws-s3__: Bucket notifications can now add dependencies, fixing creation order ([@eladb] in [#584](#584)). * __@aws-cdk/aws-s3__: Remove useless bucket name validation ([@rix0rrr] in [#628](#628)). * __@aws-cdk/aws-sqs__: Make `QueueRef.encryptionMasterKey` readonly ([@RomainMuller] in [#650](#650)). * __assets__: S3 read permissions are granted on a prefix to fix lost permissions during asset update ([@rix0rrr] in [#510](#510)). * __aws-cdk__: Remove bootstrapping error if multiple stacks are in the same environment ([@RomainMuller] in [#625](#625)). * __aws-cdk__: Report and continue if git throws errors during `cdk init` ([@rix0rrr] in [#587](#587)). * __@aws-cdk/cfnspec__: Updated [CloudFormation resource specification] to `v2.6.0` ([@RomainMuller] in [#594](#594)) + **New AWS Construct Library** - `@aws-cdk/aws-sagemaker` supports AWS::SageMaker resources + **New Resource Types** - AWS::AmazonMQ::Broker - AWS::AmazonMQ::Configuration - AWS::CodePipeline::Webhook - AWS::Config::AggregationAuthorization - AWS::Config::ConfigurationAggregator - AWS::EC2::VPCEndpointConnectionNotification - AWS::EC2::VPCEndpointServicePermissions - AWS::IAM::ServiceLinkedRole - AWS::SSM::ResourceDataSync - AWS::SageMaker::Endpoint - AWS::SageMaker::EndpointConfig - AWS::SageMaker::Model - AWS::SageMaker::NotebookInstance - AWS::SageMaker::NotebookInstanceLifecycleConfig + **Attribute Changes** - AWS::CodePipeline::Pipeline Version (__added__) + **Property Changes** - AWS::AppSync::DataSource HttpConfig (__added__) - AWS::DAX::Cluster SSESpecification (__added__) - AWS::DynamoDB::Table Stream (__added__) - AWS::DynamoDB::Table AutoScalingSupport (__added__) - AWS::EC2::VPCEndpoint IsPrivateDnsEnabled (__added__) - AWS::EC2::VPCEndpoint SecurityGroupIds (__added__) - AWS::EC2::VPCEndpoint SubnetIds (__added__) - AWS::EC2::VPCEndpoint VPCEndpointType (__added__) - AWS::EC2::VPCEndpoint RouteTableIds.DuplicatesAllowed (__deleted__) - AWS::EC2::VPCPeeringConnection PeerRegion (__added__) - AWS::EFS::FileSystem ProvisionedThroughputInMibps (__added__) - AWS::EFS::FileSystem ThroughputMode (__added__) - AWS::EMR::Cluster KerberosAttributes (__added__) - AWS::Glue::Classifier JsonClassifier (__added__) - AWS::Glue::Classifier XMLClassifier (__added__) - AWS::Glue::Crawler Configuration (__added__) - AWS::Lambda::Lambda DLQConfigurationSupport (__added__) - AWS::Neptune::DBInstance DBSubnetGroupName.UpdateType (__changed__) - Old: Mutable - New: Immutable - AWS::SNS::Subscription DeliveryPolicy (__added__) - AWS::SNS::Subscription FilterPolicy (__added__) - AWS::SNS::Subscription RawMessageDelivery (__added__) - AWS::SNS::Subscription Region (__added__) - AWS::SQS::Queue Tags (__added__) - AWS::ServiceDiscovery::Service HealthCheckCustomConfig (__added__) + **Property Type Changes** - AWS::AppSync::DataSource.HttpConfig (__added__) - AWS::DAX::Cluster.SSESpecification (__added__) - AWS::EMR::Cluster.KerberosAttributes (__added__) - AWS::Glue::Classifier.JsonClassifier (__added__) - AWS::Glue::Classifier.XMLClassifier (__added__) - AWS::ServiceDiscovery::Service.HealthCheckCustomConfig (__added__) - AWS::CloudFront::Distribution.CacheBehavior FieldLevelEncryptionId (__added__) - AWS::CloudFront::Distribution.DefaultCacheBehavior FieldLevelEncryptionId (__added__) - AWS::CodeBuild::Project.Artifacts EncryptionDisabled (__added__) - AWS::CodeBuild::Project.Artifacts OverrideArtifactName (__added__) - AWS::CodeBuild::Project.Environment Certificate (__added__) - AWS::CodeBuild::Project.Source ReportBuildStatus (__added__) - AWS::ServiceDiscovery::Service.DnsConfig RoutingPolicy (__added__) - AWS::WAF::WebACL.ActivatedRule Action.Required (__changed__) - Old: true - New: false * __@aws-cdk/cfnspec__: Updated Serverless Application Model (SAM) Resource Specification ([@RomainMuller] in [#594](#594)) + **Property Changes** - AWS::Serverless::Api MethodSettings (__added__) + **Property Type Changes** - AWS::Serverless::Function.SQSEvent (__added__) - AWS::Serverless::Function.EventSource Properties.Types (__changed__) - Added SQSEvent

RomainMuller and others added 3 commits August 22, 2018 15:10

Revert "Disable .NET targets (the JSII runtime is not yet published t…

5cf23e9

…o Nuget)" This reverts commit 5d116e3.

Add init template for .NET.

7350af5

Undo workarounds for developing on Windows before submitting pull req…

eb1d5fa

…uest.

mpiroc requested review from eladb, RomainMuller and costleya August 22, 2018 22:32

rix0rrr reviewed Aug 23, 2018

View reviewed changes

tools/pkglint/lib/rules.ts Show resolved Hide resolved

costleya suggested changes Aug 23, 2018

View reviewed changes

mpiroc mentioned this pull request Aug 24, 2018

jsii.targets.dotnet.packageId should be optional, and default to jsii.targets.dotnet.namespace when omitted. aws/jsii#198

Closed

mpiroc added 2 commits August 24, 2018 16:22

Address feedback from code review.

1257134

Merge remote-tracking branch 'origin/master' into pirocchi/init

c8ea961

eladb reviewed Aug 28, 2018

View reviewed changes

mpiroc mentioned this pull request Aug 30, 2018

Enable creation of strong names for .NET assemblies. #643

Merged

mpiroc added 3 commits September 4, 2018 11:40

Merge branch 'master' into pirocchi/init

a20587a

Integrate the latest changes from master, and address comments from c…

71bc8e7

…ode review.

Clean up formatting.

cbb608f

leepa reviewed Sep 5, 2018

View reviewed changes

mpiroc added 3 commits September 5, 2018 10:16

Do not require cdk-build-tools at runtime.

fd0055b

Remove WSL workarounds.

2945336

Restore newlines at end of package.json files.

42681ff

eladb approved these changes Sep 6, 2018

View reviewed changes

mpiroc added 2 commits September 6, 2018 10:44

Merge branch 'master' into pirocchi/init

ffd1734

Fix init template permissions and build.

a1a0372

costleya approved these changes Sep 7, 2018

View reviewed changes

Rico Huijbers added 2 commits September 10, 2018 20:39

Merge branch 'master' into pirocchi/init

b342a41

Re-enable JSX tests

6cbfbaf

Force rerun of GitHub checks

4db197a

rix0rrr merged commit 34655f2 into master Sep 11, 2018

rix0rrr mentioned this pull request Sep 11, 2018

v0.9.0 #688

Merged

mpiroc mentioned this pull request Sep 17, 2018

cdk-init template for .NET #457

Closed


		protected readonly autoCreatePolicy = true;

		private _encryptionMasterKey?: kms.EncryptionKeyRef;

Add cdk init template for .NET, and re-enable .NET targets #617

Add cdk init template for .NET, and re-enable .NET targets #617

Conversation

mpiroc commented Aug 22, 2018

rix0rrr commented Aug 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rix0rrr Aug 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rix0rrr commented Aug 23, 2018

mpiroc commented Aug 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rix0rrr commented Aug 24, 2018

mpiroc commented Aug 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpiroc commented Sep 5, 2018

eladb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rix0rrr commented Sep 10, 2018

Add `cdk init` template for .NET, and re-enable .NET targets #617

Add `cdk init` template for .NET, and re-enable .NET targets #617

rix0rrr Aug 23, 2018 •

edited

Loading