Added DynamoDB Table Stream

[rhboyd]

added the ability to create a DDB Stream in the L2 construct. Change is backwards compatible in that it will not enable a stream if the stream property isn't set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

[eladb]

We usually don't like to expose the raw CloudFormation data types in this layer since normally there's a way to provide a richer API. This is a great example for this. the [StreamSpecification] property basically has a single string field that can accept a bunch of possible values. Instead of sending users to read the docs and find what are the allowed values (failing only in deploy-time), we can just provide a simple enum:

export enum StreamViewType {
  NewImage = 'NEW_IMAGE',
  OldImage = 'OLD_IMAGE',
  NewAndOldImages = 'NEW_AND_OLD_IMAGES',
  KeysOnly = 'KEYS_ONLY'
}

Also, copy & paste the documentation from the DynamoDB manual as jsdocs on these enum members so users have all the information.

I also don't see any need for a nested structure here. We can use the fact that this is an optional field to determine if streams are enabled. So you can just call this streamViewType and indicate under @default that if this is not defined, DDB streams are disabled.

[rhboyd]

Awesome. I’ll make these changes today.

…

On Aug 28, 2018, at 2:29 AM, Elad Ben-Israel ***@***.***> wrote: @eladb requested changes on this pull request. In ***@***.***/aws-dynamodb/lib/table.ts: > @@ -23,6 +23,12 @@ export interface TableProps { * @default <generated> */ tableName?: string; + + /** + * The Type of Stream to create. + * @default '' + */ + streamSpecification?: cloudformation.TableResource.StreamSpecificationProperty; We usually don't like to expose the raw CloudFormation data types in this layer since normally there's a way to provide a richer API. This is a great example for this. the [StreamSpecification] property basically has a single string field that can accept a bunch of possible values. Instead of sending users to read the docs and find what are the allowed values (failing only in deploy-time), we can just provide a simple enum: export enum StreamViewType { NewImage = 'NEW_IMAGE', OldImage = 'OLD_IMAGE', NewAndOldImages = 'NEW_AND_OLD_IMAGES', KeysOnly = 'KEYS_ONLY' } Also, copy & paste the documentation from the DynamoDB manual as jsdocs on these enum members so users have all the information. I also don't see any need for a nested structure here. We can use the fact that this is an optional field to determine if streams are enabled. So you can just call this streamViewType and indicate under @default that if this is not defined, DDB streams are disabled. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[eladb]

broken sentence

[eladb]

Describe what the default behavior is. In this case, "streams are disabled for this table" or something along these lines

[eladb]

Not needed

[eladb]

A couple of minor fixes and we'll merge this in

[eladb]

Cool, I'll wait for the PR builds to pass and merge in