feat(cloud9): support AWS CodeCommit repository clone on launch #8205

pahud · 2020-05-26T13:36:00Z

feat(cloud9): support AWS CodeCommit repository clone on launch

Add a new repositories property to allow users to clone AWS CodeCommit repositories on environment launch.

Closes #8204

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation · 2020-05-26T14:25:18Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 9b32483
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-26T14:25:42Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: cc3fe0b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85

Thanks for the contribution @pahud ! Looks good, some minor comments (and one important question) below.

packages/@aws-cdk/aws-cloud9/README.md

packages/@aws-cdk/aws-cloud9/lib/environment.ts

packages/@aws-cdk/aws-cloud9/package.json

packages/@aws-cdk/aws-cloud9/test/cloud9.environment.test.ts

packages/@aws-cdk/aws-cloud9/test/integ.cloud9.ts

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Pull request has been modified.

aws-cdk-automation · 2020-05-27T04:48:57Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 4caed1b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-27T05:19:38Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 2aa8a33
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-27T05:48:24Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: b1a44f1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-cloud9/lib/environment.ts

aws-cdk-automation · 2020-05-27T11:44:24Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: fdf27e6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-27T12:07:50Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 2818bfa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-28T16:12:33Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 6676a61
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…po-support

aws-cdk-automation · 2020-05-29T00:13:25Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 7f514cc
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-05-29T01:15:49Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 4fde155
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-cloud9/README.md

packages/@aws-cdk/aws-cloud9/lib/environment.ts

…po-support

eladb

@skinny85 This mostly LGTM. Please check this out.

packages/@aws-cdk/aws-cloud9/README.md

packages/@aws-cdk/aws-cloud9/lib/environment.ts

aws-cdk-automation · 2020-06-02T06:24:56Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: f217fe8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-06-02T06:26:11Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 97586eb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-06-02T08:02:44Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 64408d9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-06-02T08:16:05Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 8db4e4a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85 · 2020-06-02T18:32:58Z

@pahud before I review, I want to understand something first.

Do you not need any permissions on the CodeCommit repo that you're cloning? Did you try and spin up a new Cloud9 environment with this functionality, and was the repository cloned correctly?

pahud · 2020-06-03T01:25:46Z

@pahud before I review, I want to understand something first.

Do you not need any permissions on the CodeCommit repo that you're cloning? Did you try and spin up a new Cloud9 environment with this functionality, and was the repository cloned correctly?

Yes. I have run two tests:

The first one is to create a new codecommit repo and cloud9 environment in the same stack, which is exactly what my integ test does

import * as codecommit from '@aws-cdk/aws-codecommit';
import * as ec2 from '@aws-cdk/aws-ec2';
import * as cdk from '@aws-cdk/core';
import * as cloud9 from '../lib';

export class Cloud9Env extends cdk.Stack {
  constructor(scope: cdk.Construct, id: string, props?: cdk.StackProps) {
    super(scope, id, props);

    const vpc = new ec2.Vpc(this, 'VPC', {
      maxAzs: 2,
      natGateways: 1,
    });

    // create a codecommit repository to clone into the cloud9 environment
    const repo = new codecommit.Repository(this, 'Repo', {
      repositoryName: 'foo',
    });

    // create a cloud9 ec2 environment in a new VPC
    const c9env = new cloud9.Ec2Environment(this, 'C9Env', {
      vpc,
      // clone repositories into the environment
      clonedRepositories: [
        cloud9.CloneRepository.fromCodeCommit(repo, '/foo'),
      ],
    });
    new cdk.CfnOutput(this, 'URL', { value: c9env.ideUrl });
    new cdk.CfnOutput(this, 'ARN', { value: c9env.ec2EnvironmentArn });
  }
}

const app = new cdk.App();

new Cloud9Env(app, 'C9Stack');

The c9 environment and codecommit repo all created correctly and when I click the cloud9 URL:

It just cloned the new codecommit repo into the target path I specified, though the repo is empty I still can see the .git folder inside.

Another test is to create a new cloud9 environment and clone an existing codecommit repository which I created manually.

    // import an existing codecommit repo
    const repo = codecommit.Repository.fromRepositoryName(this, 'Repo', 'wildrydes-site');

    const c9env = new cloud9.Ec2Environment(this, 'C9Env', {
      vpc,
      // clone repositories into the environment
      clonedRepositories: [
        cloud9.CloneRepository.fromCodeCommit(repo, '/foo'),
      ],
    });

To make it clear, I just updated the README with this sample:

Cloning Repositories

Use clonedRepositories to clone one or multiple AWS Codecommit repositories into the environment:

// create a codecommit repository to clone into the cloud9 environment
const repoNew = new codecommit.Repository(this, 'RepoNew', {
  repositoryName: 'new-repo',
});

// import an existing codecommit repository to clone into the cloud9 environment
const repoExisting = codecommit.Repository.fromRepositoryName(stack, 'RepoExisting', 'existing-repo');

// create a new Cloud9 environment and clone the two repositories
new cloud9.Ec2Environment(stack, 'C9Env', {
  vpc,
  clonedRepositories: [
    cloud9.CloneRepository.fromCodeCommit(repoNew, '/src/new-repo'),
    cloud9.CloneRepository.fromCodeCommit(repoExisting, '/src/existing-repo'),
  ],
});

And both repos were cloned correctly as expected:

aws-cdk-automation · 2020-06-03T02:18:02Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 6f8f1a4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-06-03T02:36:31Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 836fa5f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85

Thanks for the great contribution @pahud !

skinny85 · 2020-06-02T18:30:52Z

packages/@aws-cdk/aws-cloud9/lib/environment.ts

+   *
+   * @default - do not clone any repository
+   */
+  // readonly clonedRepositories?: Cloud9Repository[];


No need for this commented out line anymore.

mergify · 2020-06-08T20:16:31Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2020-06-08T21:01:49Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: ef1b585
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-06-08T21:02:09Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

pahud added 2 commits May 26, 2020 21:31

support codecommit repository

9b32483

Merge branch 'master' into c9-repo-support

cc3fe0b

SomayaB assigned skinny85 May 26, 2020

skinny85 previously requested changes May 27, 2020

View reviewed changes

Update packages/@aws-cdk/aws-cloud9/README.md

4caed1b

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

pahud added 3 commits May 27, 2020 12:55

fix

b4b6117

fix

2aa8a33

update README

b1a44f1

eladb reviewed May 27, 2020

View reviewed changes

packages/@aws-cdk/aws-cloud9/lib/environment.ts Outdated Show resolved Hide resolved

pahud added 2 commits May 27, 2020 19:16

add CloneRepository class with fromCodeCommit() support

2818bfa

Merge branch 'master' into c9-repo-support

fdf27e6

pahud marked this pull request as draft May 28, 2020 15:19

Merge branch 'master' into c9-repo-support

6676a61

pahud added 2 commits May 29, 2020 07:26

update integ test

feefdb7

Merge branch 'c9-repo-support' of github.com:pahud/aws-cdk into c9-re…

7f514cc

…po-support

pahud marked this pull request as ready for review May 28, 2020 23:29

Merge branch 'master' into c9-repo-support

4fde155

pahud requested a review from skinny85 May 29, 2020 11:17

eladb reviewed Jun 2, 2020

View reviewed changes

packages/@aws-cdk/aws-cloud9/README.md Show resolved Hide resolved

packages/@aws-cdk/aws-cloud9/lib/environment.ts Outdated Show resolved Hide resolved

pahud added 3 commits June 2, 2020 13:30

update CloneRepository class

a0b7806

Merge branch 'c9-repo-support' of github.com:pahud/aws-cdk into c9-re…

97586eb

…po-support

Merge branch 'master' into c9-repo-support

f217fe8

eladb reviewed Jun 2, 2020

View reviewed changes

packages/@aws-cdk/aws-cloud9/README.md Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-cloud9/lib/environment.ts Show resolved Hide resolved

packages/@aws-cdk/aws-cloud9/lib/environment.ts Outdated Show resolved Hide resolved

pahud added 2 commits June 2, 2020 15:08

minor fix

64408d9

minor README update

8db4e4a

pahud added 2 commits June 3, 2020 09:26

update README

6f8f1a4

Merge branch 'master' into c9-repo-support

836fa5f

skinny85 approved these changes Jun 8, 2020

View reviewed changes

Merge branch 'master' into c9-repo-support

ef1b585

mergify bot merged commit 4781f94 into aws:master Jun 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cloud9): support AWS CodeCommit repository clone on launch #8205

feat(cloud9): support AWS CodeCommit repository clone on launch #8205

pahud commented May 26, 2020

aws-cdk-automation commented May 26, 2020

aws-cdk-automation commented May 26, 2020

skinny85 left a comment

aws-cdk-automation commented May 27, 2020

aws-cdk-automation commented May 27, 2020

aws-cdk-automation commented May 27, 2020

aws-cdk-automation commented May 27, 2020

aws-cdk-automation commented May 27, 2020

aws-cdk-automation commented May 28, 2020

aws-cdk-automation commented May 29, 2020

aws-cdk-automation commented May 29, 2020

eladb left a comment

aws-cdk-automation commented Jun 2, 2020

aws-cdk-automation commented Jun 2, 2020

aws-cdk-automation commented Jun 2, 2020

aws-cdk-automation commented Jun 2, 2020

skinny85 commented Jun 2, 2020

pahud commented Jun 3, 2020 •

edited

Loading

aws-cdk-automation commented Jun 3, 2020

aws-cdk-automation commented Jun 3, 2020

skinny85 left a comment

skinny85 Jun 2, 2020

mergify bot commented Jun 8, 2020

aws-cdk-automation commented Jun 8, 2020

mergify bot commented Jun 8, 2020

feat(cloud9): support AWS CodeCommit repository clone on launch #8205

feat(cloud9): support AWS CodeCommit repository clone on launch #8205

Conversation

pahud commented May 26, 2020

aws-cdk-automation commented May 26, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 26, 2020

AWS CodeBuild CI Report

skinny85 left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented May 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 28, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 29, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented May 29, 2020

AWS CodeBuild CI Report

eladb left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Jun 2, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jun 2, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jun 2, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jun 2, 2020

AWS CodeBuild CI Report

skinny85 commented Jun 2, 2020

pahud commented Jun 3, 2020 • edited Loading

Cloning Repositories

aws-cdk-automation commented Jun 3, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jun 3, 2020

AWS CodeBuild CI Report

skinny85 left a comment

Choose a reason for hiding this comment

skinny85 Jun 2, 2020

Choose a reason for hiding this comment

mergify bot commented Jun 8, 2020

aws-cdk-automation commented Jun 8, 2020

AWS CodeBuild CI Report

mergify bot commented Jun 8, 2020

pahud commented Jun 3, 2020 •

edited

Loading