Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eks): support create namespace with helm #8787

Merged
merged 6 commits into from
Jun 30, 2020
Merged

chore(eks): support create namespace with helm #8787

merged 6 commits into from
Jun 30, 2020

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jun 29, 2020 •
edited
Loading

chore(eks): support create namespace with helm

  • add createNamespace property for eks.HelmChart
  • set the wait flag correctly for HelmChart custom resource

Fixes: #7216 #7209 #8713

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@pahud
Copy link
Contributor Author

pahud commented Jun 29, 2020 •
edited
Loading

Hi @eladb

PR ready. And createNamespace default is true now. Some considerations:

  1. Helm3 CLI by default doesn't enable --create-namespace unless explicitly specified though I agree it makes sense to enable by default.

  2. If we enable this by default, when users deploy the stack again with this patch, all deployed helm chart resources will be updated or replaced.

What do you think?

@pahud
Copy link
Contributor Author

pahud commented Jun 29, 2020

Another question - are we supposed to use any auto-formatting tool when editing python in VSCode or better just turn it off?

If I enable the auto-formatting, the whole python file gets re-formatted, which makes the code review difficult.

eladb
eladb previously requested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have an issue with booleans...

packages/@aws-cdk/aws-eks/lib/kubectl-handler/helm/__init__.py Show resolved Hide resolved
@eladb eladb mentioned this pull request Jun 29, 2020
Merged
@eladb eladb mentioned this pull request Jun 30, 2020
Closed
@mergify mergify bot dismissed eladb’s stale review June 30, 2020 06:28

Pull request has been modified.

eladb
eladb previously approved these changes Jun 30, 2020
View reviewed changes
@mergify mergify bot dismissed eladb’s stale review June 30, 2020 06:54

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7b1c670
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 973fa42 into aws:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-eks] Upgrade to kubectl 1.15 & AWS CLI 1.18.70
3 participants
@pahud @aws-cdk-automation @eladb