chore(cloudfront): README updates and notes of breaking changes #9356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making a small -- but useful -- README change as an excuse to capture the breaking changes made in #9326, but that were missed in that commit message. BREAKING CHANGE: Removed origin classes from the aws-cloudfront module. * **aws-cloudfront:** Removed S3Origin and HttpOrigin from the aws-cloudfront module. Use the S3Origin and HttpOrigin classes in the aws-cloudfront-origins module instead. * **aws-cloudfront:** Renamed Origin to OriginBase.
shivlaks
approved these changes
Jul 30, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
…9356) Making a small -- but useful -- README change as an excuse to capture the breaking changes made in aws#9326, but that were missed in that commit message. BREAKING CHANGE: Removed origin classes from the aws-cloudfront module. * **aws-cloudfront:** Removed S3Origin and HttpOrigin from the aws-cloudfront module. Use the S3Origin and HttpOrigin classes in the aws-cloudfront-origins module instead. * **aws-cloudfront:** Renamed Origin to OriginBase. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a small -- but useful -- README change as an excuse to capture the
breaking changes made in #9326, but that were missed in that commit message.
BREAKING CHANGE: Removed origin classes from the cloudfront module.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license