Cloudfront sign #1668
Cloudfront sign #1668
Conversation
|
Currently the CI tests fail because the boto/botocore#735 is not yet merged. I run test cases for this PR on my local environment and they pass. Please review. Thanks! |
| YYYY-MM-DD (which means 0AM UTC of that day), | ||
| YYYY-MM-DDThh:mm:ss (with default timezone as UTC), | ||
| YYYY-MM-DDThh:mm:ss+hh:mm or YYYY-MM-DDThh:mm:ss-hh:mm (with offset), | ||
| or EpochTime. |
There was a problem hiding this comment.
I assume epoch will also assume UTC? Probably worth documenting.
|
Just had some small comments. |
rayluo
force-pushed
the
cloudfront-sign
branch
from
d539664
to
741e1a0
Compare
| 'required': True, | ||
| 'help_text': 'The ID of your CloudFront key pairs.', | ||
| }, | ||
| { |
There was a problem hiding this comment.
What does the private-key represent? Its good that you put how to specify it but it tells the user nothing about the private key. For a few of these arguments it seems that we are making the assumption the user has read the cloudfront docs. I do not think this should be necessary to use the sign command.
|
Looks good. Just had some small comments |
rayluo
force-pushed
the
cloudfront-sign
branch
from
741e1a0
to
a14dc95
Compare
|
LGTM 🚢 |
| @@ -9,6 +9,7 @@ Next Release (TBD) | |||
| (`issue 1664 <https://github.com/aws/aws-cli/pull/1664>`__) | |||
| * feature:``aws cloudfront create-invalidation``: Add a new --paths option. | |||
| (`issue 1662 <https://github.com/aws/aws-cli/pull/1662>`__) | |||
| * feature:``aws cloudfront sign``: Add a new command to sign url. | |||
There was a problem hiding this comment.
grammar's off here, maybe "...to create a signed url"?
|
|
rayluo
force-pushed
the
cloudfront-sign
branch
from
a1c0acb
to
c56d859
Compare
jamesls
added
pr:ready-to-merge
This PR depends on boto/botocore#735
This PR also supersedes #1459.