Feature cloudfront sign #735
Conversation
setup.py and requirements.txt are also updated to include new dependency rsa.
rayluo
added
the
pr/needs-review
| def datetime2timestamp(dt): | ||
| """Calculate the timestamp based on the given datetime instance. | ||
|
|
||
| Naive datetime input will be treated as UTC time rather than local time. |
There was a problem hiding this comment.
Curious to see what others think about this. A utility function further down in this module does the same thing, but that was specifically for back-compat to fix a regression. Not sure if it makes sense to carry that forward.
We'd still have to support the no timezone == UTC in the CLI, but we don't necessarily have to have that throughout the botocore utility methods. I could go either way.
| :type rsa_signer: callable | ||
| :param rsa_signer: An RSA signer. | ||
| Its only input parameter will be the message to be signed, | ||
| and its output will be the signed content as a binary string. |
There was a problem hiding this comment.
Also may be good to say that it requires SHA-1
There was a problem hiding this comment.
Done. See the next line in code.
|
Looks good. Just had some small comments and questions that would be good to discuss. |
jamesls
added
incorporating-feedback
and removed
pr/needs-review
…d custom policies
rayluo
force-pushed
the
feature-cloudfront-sign
branch
from
e4125f0
to
0c541a2
Compare
rayluo
added
pr/needs-review
| # Note: | ||
| # 1. Order in canned policy is significant. Special care has been taken | ||
| # to ensure the output will match the order defined by document. | ||
| # There is also a test case in this commit to ensure that order. |
There was a problem hiding this comment.
Remove reference to "this commit". That's very easy to get out of date as changes are made.
|
|
|
🚢 One possibility for a future addition: did you consider adding a helper method to create an rsa_signer for the user? For example, maybe it could be a function that accepts that path to a private key and returns a function that could be given to |
|
Thanks 🚢 |
rayluo
added
enhancement
|
|
||
| First you create a cloudfront signer based on a normalized RSA signer:: | ||
|
|
||
| import rsa |
There was a problem hiding this comment.
Your example should use cryptography instead of rsa.
Provide the signer class. It will be used in CLI soon.
Also note that there is no (hard) dependency of rsa in this implementation.