kn: merge to main #178

lauzadis · 2025-08-14T16:14:02Z

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* fix glibc version to 2.19 by using manylinux images. * fix aarch64 to not use `moutline-atomics` by using the same toolchain that K/N is using

…ough to composite builds

This reverts commit ab7851f.

kn: merge from main (again?)

lauzadis · 2025-08-14T17:21:06Z

.github/workflows/ci.yaml

+        uses: ./.github/actions/setup-build
+      - name: Configure Docker Images
+        run: |
+          ./docker-images/build-images.sh linux-x64 linux-arm64


note: @ianbotsf We are still using Docker for Linux CI, I will need to think about how we remove Docker later.

lauzadis · 2025-08-14T17:23:54Z

aws-crt-kotlin/common/test/aws/sdk/kotlin/crt/auth/credentials/CredentialsProviderTest.kt

 private val EXPECTED_CREDENTIALS = Credentials("access_key_id", "secret_access_key", "session_token")

 class CredentialsProviderTest : CrtTest() {
+    @Ignore // FIXME Enable when Kotlin/Native implementation is complete


note: we haven't implemented Native credentials providers with bindings to CRT (and probably never will?) since we have common implementations in smithy-kotlin

Can you mention that in the comment please, unless it's documented somewhere else

ianbotsf · 2025-08-14T17:22:36Z

.changes/5b6cf8f2-eff6-4def-a335-1de5052a810a.json

+{
+    "id": "5b6cf8f2-eff6-4def-a335-1de5052a810a",
+    "type": "feature",
+    "description": "Add support for Kotlin/Native"
+}


Nit: Link to public issue

ianbotsf · 2025-08-14T17:26:58Z

.changes/5b6cf8f2-eff6-4def-a335-1de5052a810a.json

+{
+    "id": "5b6cf8f2-eff6-4def-a335-1de5052a810a",
+    "type": "feature",
+    "description": "Add support for Kotlin/Native"
+}


Correctness: "requiresMinorVersionBump": true

ianbotsf · 2025-08-14T17:32:17Z

aws-crt-kotlin/jvm/test/aws/sdk/kotlin/crt/http/HttpRequestResponseTest.kt

+    @Ignore // FIXME This test is broken since switching runSuspendingTest to runTest
    @Test
-    fun testHttpGet() = runSuspendTest {
+    fun testHttpGet() = runTest {
        testSimpleRequest("GET", "/get", 200)
        testSimpleRequest("GET", "/post", 405)
        testSimpleRequest("GET", "/put", 405)
        testSimpleRequest("GET", "/delete", 405)
    }


Question: What's the path to getting these ignored tests working again?

We'll need to investigate why they no longer work after moving away from runSuspendingTest, I made a backlog task SDK-KT-774 if that works for you?

Did you stop using runSuspendTest because it was basically a copy of runTest? It's a little concerning to leave that test disabled. Can you temporarily enable it by switching back to runSuspendTest or some other alternative. Unless it's related to something in our native implementation I think it should fine to use runSuspendTest for now.

No. I replaced it because there was a TODO saying we should. runSuspendTest does not exist anymore. I just updated this to use runBlocking (which is what runSuspendTest used before). It works fine now

Sounds good to me, thanks for capturing a backlog item.

Actually it was fixed thanks to @0marperez question, I decided to use runBlocking and everything works now

0marperez · 2025-08-14T21:45:42Z

aws-crt-kotlin/jvm/test/aws/sdk/kotlin/crt/http/HttpRequestResponseTest.kt

+    @Ignore // FIXME This test is broken since switching runSuspendingTest to runTest
    @Test
-    fun testHttpGet() = runSuspendTest {
+    fun testHttpGet() = runTest {
        testSimpleRequest("GET", "/get", 200)
        testSimpleRequest("GET", "/post", 405)
        testSimpleRequest("GET", "/put", 405)
        testSimpleRequest("GET", "/delete", 405)
    }


Did you stop using runSuspendTest because it was basically a copy of runTest? It's a little concerning to leave that test disabled. Can you temporarily enable it by switching back to runSuspendTest or some other alternative. Unless it's related to something in our native implementation I think it should fine to use runSuspendTest for now.

sonarqubecloud · 2025-08-14T21:59:15Z

Quality Gate passed

Issues
39 New issues
0 Accepted issues

Measures
5 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-08-14T21:59:39Z

Affected Artifacts

Changed in size

Artifact	Pull Request (bytes)	Latest Release (bytes)	Delta (bytes)	Delta (percentage)
aws-crt-kotlin-jvm.jar	221,683	216,897	4,786	2.21%

aajtodd and others added 30 commits February 13, 2024 09:04

chore: bootstrap CRT build for native platforms (#91)

bbc7cf1

chore: bootsrap kotlin native CI (#92)

b5c745c

(kn) feat: initial Allocator, logging, CrtResource implementations (#93)

700af3d

fix: use same toolchain on arm that k/n does (#95)

ef8137a

* fix glibc version to 2.19 by using manylinux images. * fix aarch64 to not use `moutline-atomics` by using the same toolchain that K/N is using

misc: Kotlin/Native IO implementation (#96)

9908822

feat: k/n http bindings (#97)

082670c

setup basic logging for native and fix static libs (#98)

ee467c8

fix: iOS simulator TLS negotiation errors (#101)

4b10e82

feat: add support for native checksums (#100)

a79c167

kn: signing (#103)

938a6b1

Merge branch 'main' of github.com:awslabs/aws-crt-kotlin into kn-main

886798f

Fix merge

b9b99f7

ktlint

69d9c7d

git submodule update

d254084

Merge branch 'main' of github.com:awslabs/aws-crt-kotlin into kn-main

147cd68

misc: clean up build scripts (#119)

6eaf028

kn: lift build logic into aws-kotlin-repo-tools (#120)

f059811

kn: checksum bindings (#121)

375b817

Add WithCrt to MutableBuffer

ff3a81d

ktlintFormat

adb9e36

kn: merge from main (#127)

22e9b92

kn: merge from main, upgrade to latest aws-kotlin-repo-tools (#129)

f8bc8d7

kn: upgrade to latest build plugin (#130)

f77f3f8

kn: move WithCrt to common source set (#137)

a76360f

kn: make log public for CrtLogger (#138)

3cd6fda

kn: initialize CRT in TlsContext (#140)

aed1325

kn: parallelize CMake builds (#142)

e6e18b4

Use providers.gradleProperty which allows passing of properties thr…

d3c8108

…ough to composite builds

kn: upgrade crt dependencies (#135)

91a33a8

Only attempt to cross-compile on non-Linux hosts

7073b54

lauzadis added 8 commits August 14, 2025 12:17

Delete run-container-test script

ab7851f

Re-enable K/N for artifactSizeMetrics task?

0596588

Revert "Delete run-container-test script"

ce6bfcb

This reverts commit ab7851f.

Can we enable this test now?

c21eec1

minor fixes

09e6d0b

Disable K/N for artifact size metrics

0e42b2d

kn: final merge from main! (#177)

b32411a

Merge pull request #179 from awslabs/kn-main-merge

533a897

kn: merge from main (again?)

This comment has been minimized.

Sign in to view

lauzadis commented Aug 14, 2025

View reviewed changes

ianbotsf requested changes Aug 14, 2025

View reviewed changes

Add changelog with link to issue and requiresMinorVersionBump

3a74f8f

This comment has been minimized.

Sign in to view

lauzadis added the acknowledge-api-break Acknowledge that a change is API breaking and may be backwards-incompatible. Review carefully! label Aug 14, 2025

lauzadis requested a review from ianbotsf August 14, 2025 18:58

This comment has been minimized.

Sign in to view

lauzadis added 2 commits August 14, 2025 15:02

update comment

495d7c4

update one more comment

c72c6e9

This comment has been minimized.

Sign in to view

lauzadis requested a review from 0marperez August 14, 2025 21:14

0marperez requested changes Aug 14, 2025

View reviewed changes

Replace runTest with runBlocking

fd7aaef

lauzadis requested a review from 0marperez August 14, 2025 21:58

0marperez approved these changes Aug 14, 2025

View reviewed changes

ianbotsf approved these changes Aug 15, 2025

View reviewed changes

lauzadis merged commit f930be4 into main Aug 15, 2025
96 of 103 checks passed

kn: merge to main #178

kn: merge to main #178

Uh oh!

Conversation

lauzadis commented Aug 14, 2025

Uh oh!

This comment has been minimized.

lauzadis Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 14, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Aug 14, 2025

Affected Artifacts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lauzadis Aug 14, 2025 •

edited

Loading