fix(Java): Improve Collection of Errors string #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
requested changes
Nov 26, 2024
AwsCryptographyPrimitives/codegen-patches/java/dafny-4.9.0.patch
Outdated
Show resolved
Hide resolved
texastony
force-pushed
the
tony/fix-java-collection-of-error-message
branch
from
e62d595 to
56b1c53
Compare
...icMaterialProviders/codegen-patches/AwsCryptographicMaterialProviders/java/dafny-4.9.0.patch
Outdated
Show resolved
Hide resolved
...ryptographicMaterialProviders/codegen-patches/AwsCryptographyKeyStore/java/dafny-4.9.0.patch
Outdated
Show resolved
Hide resolved
Update was created by: for FILE in $(find */runtimes/java/** -name "CollectionOfErrors.java"); do emacs $FILE; done for FILE in $(find */runtimes/java/** -name "CollectionOfErrors.java"); do git add $FILE; done cd TestVectorsAwsCryptographicMaterialProviders gmake polymorph_java DAFNY_VERSION=4.9.0 POLYMORPH_OPTIONS=--update-patch-files |& tee poly.log |& less -r +F
texastony
force-pushed
the
tony/fix-java-collection-of-error-message
branch
from
56b1c53 to
1053457
Compare
RitvikKapila
pushed a commit
that referenced
this pull request
Jan 31, 2025
# [1.9.0](v1.8.0...v1.9.0) (2025-01-31) ### Bug Fixes * CI ([d9e2a1e](d9e2a1e)) * DafnyLibraries.FileIO extern ([b150c48](b150c48)) * ECDH ValidatePublicKey err msg ([34a48fc](34a48fc)) * for test vectors, use SetToSequenceSorted ([#1034](#1034)) ([21ad206](21ad206)) * **GHW:** check-files apply to PR, not to diff b/w HEAD and branch ([#1075](#1075)) ([1f53a92](1f53a92)) * improve golang externs ([#1133](#1133)) ([b6ee16e](b6ee16e)) * **Java:** Improve Collection of Errors string ([#1056](#1056)) ([9e195a1](9e195a1)) * line breaks ([21536c7](21536c7)) * PR comments ([798214b](798214b)) * PR comments ([a21c0b3](a21c0b3)) * PR comments ([7dd95bc](7dd95bc)) * PR comments ([eed0d87](eed0d87)) * PR comments ([435515e](435515e)) * re-enable aes_gcm_192 ([#1143](#1143)) ([23650a9](23650a9)) * region ([5930ae4](5930ae4)) * region ([e3454b5](e3454b5)) * remove [@sensitive](https://github.com/sensitive) from smithy models ([#1123](#1123)) ([c939f3a](c939f3a)) * repo rename ([#1218](#1218)) ([c2f003c](c2f003c)) * revert pyproject.toml drop ([b5dbb5c](b5dbb5c)) * rust code used for testing must be allowed dead code ([#1148](#1148)) ([5997919](5997919)) * SetToSequence should be a method, not a function ([#1035](#1035)) ([1169bc8](1169bc8)) * smithy-dafny ([#1136](#1136)) ([6005777](6005777)) ### Features * Adds CI ([511ed35](511ed35)) * check in polymorph go generated code ([#1137](#1137)) ([d0fefbf](d0fefbf)) * Check-in polymorph generated code ([bfc7cb9](bfc7cb9)) * ddb Go externs ([1e3737b](1e3737b)) * **ddb:** Go release v0.0.1 ([#1201](#1201)) ([5293bfd](5293bfd)) * **ddb:** Go release v0.0.3 ([#1210](#1210)) ([983f553](983f553)) * **Go:** Go module rename ([#1196](#1196)) ([b0876ac](b0876ac)) * kms externs for Go ([2d1f6d1](2d1f6d1)) * **kms:** Go release v0.0.1 ([#1199](#1199)) ([9c80544](9c80544)) * mpl externs ([#1105](#1105)) ([29bc52e](29bc52e)) * **mpl:** Go release v0.0.1 ([#1211](#1211)) ([4508ab8](4508ab8)) * Primitives CI ([ce6e942](ce6e942)) * Primitives for Go ([8066826](8066826)) * **primitives:** Go release v0.0.1 ([#1203](#1203)) ([6bf0bbe](6bf0bbe)) * StandardLibrary for Go ([587b57e](587b57e)) * StandardLibrary for Go ([94b4fd0](94b4fd0)) * StandardLibrary for Go ([6ce1ce3](6ce1ce3)) * **StdLib:** Go v0.0.1 release ([#1195](#1195)) ([95e54bf](95e54bf))
RitvikKapila
pushed a commit
that referenced
this pull request
Feb 3, 2025
# [1.9.0](v1.8.0...v1.9.0) (2025-02-03) ### Bug Fixes * CI ([d9e2a1e](d9e2a1e)) * DafnyLibraries.FileIO extern ([b150c48](b150c48)) * ECDH ValidatePublicKey err msg ([34a48fc](34a48fc)) * for test vectors, use SetToSequenceSorted ([#1034](#1034)) ([21ad206](21ad206)) * **GHW:** check-files apply to PR, not to diff b/w HEAD and branch ([#1075](#1075)) ([1f53a92](1f53a92)) * improve golang externs ([#1133](#1133)) ([b6ee16e](b6ee16e)) * **Java:** Improve Collection of Errors string ([#1056](#1056)) ([9e195a1](9e195a1)) * line breaks ([21536c7](21536c7)) * PR comments ([798214b](798214b)) * PR comments ([a21c0b3](a21c0b3)) * PR comments ([7dd95bc](7dd95bc)) * PR comments ([eed0d87](eed0d87)) * PR comments ([435515e](435515e)) * re-enable aes_gcm_192 ([#1143](#1143)) ([23650a9](23650a9)) * region ([5930ae4](5930ae4)) * region ([e3454b5](e3454b5)) * remove [@sensitive](https://github.com/sensitive) from smithy models ([#1123](#1123)) ([c939f3a](c939f3a)) * repo rename ([#1218](#1218)) ([c2f003c](c2f003c)) * revert pyproject.toml drop ([b5dbb5c](b5dbb5c)) * rust code used for testing must be allowed dead code ([#1148](#1148)) ([5997919](5997919)) * SetToSequence should be a method, not a function ([#1035](#1035)) ([1169bc8](1169bc8)) * smithy-dafny ([#1136](#1136)) ([6005777](6005777)) ### Features * Adds CI ([511ed35](511ed35)) * check in polymorph go generated code ([#1137](#1137)) ([d0fefbf](d0fefbf)) * Check-in polymorph generated code ([bfc7cb9](bfc7cb9)) * ddb Go externs ([1e3737b](1e3737b)) * **ddb:** Go release v0.0.1 ([#1201](#1201)) ([5293bfd](5293bfd)) * **ddb:** Go release v0.0.3 ([#1210](#1210)) ([983f553](983f553)) * **Go:** Go module rename ([#1196](#1196)) ([b0876ac](b0876ac)) * kms externs for Go ([2d1f6d1](2d1f6d1)) * **kms:** Go release v0.0.1 ([#1199](#1199)) ([9c80544](9c80544)) * mpl externs ([#1105](#1105)) ([29bc52e](29bc52e)) * **mpl:** Go release v0.0.1 ([#1211](#1211)) ([4508ab8](4508ab8)) * Primitives CI ([ce6e942](ce6e942)) * Primitives for Go ([8066826](8066826)) * **primitives:** Go release v0.0.1 ([#1203](#1203)) ([6bf0bbe](6bf0bbe)) * StandardLibrary for Go ([587b57e](587b57e)) * StandardLibrary for Go ([94b4fd0](94b4fd0)) * StandardLibrary for Go ([6ce1ce3](6ce1ce3)) * **StdLib:** Go v0.0.1 release ([#1195](#1195)) ([95e54bf](95e54bf))
This was referenced Feb 3, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Collection of Errors is a frustrating error because it requires customer action
to completely serialize it into logs.
We can make a simple fix in Java to improve the CX,
by always serializing the list into the Collection Of Error's
message.
We concatenate the given error message with
a serialization of all the nested errors.
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.